--- a/Tools__CheckinInfoDialog.st Wed Mar 30 15:34:03 2016 +0200
+++ b/Tools__CheckinInfoDialog.st Thu Mar 31 18:07:08 2016 +0200
@@ -61,6 +61,13 @@
!CheckinInfoDialog class methodsFor:'constants'!
+possibleReasons
+ ^ #(reasonBugfix reasonDocumentation reasonFeature reasonRefactoring
+ reasonOther reasonUIEnhancement reasonTuning reasonQuality)
+
+ "Created: / 31-03-2016 / 17:53:16 / cg"
+!
+
reasonBugfix
^ #reasonBugfix
!
@@ -77,10 +84,22 @@
^ #reasonOther
!
+reasonQuality
+ ^ #reasonQuality
+
+ "Created: / 31-03-2016 / 17:53:57 / cg"
+!
+
reasonRefactoring
^ #reasonRefactoring
!
+reasonTuning
+ ^ #reasonTuning
+
+ "Created: / 31-03-2016 / 17:53:26 / cg"
+!
+
reasonUIEnhancement
^ #reasonUIEnhancement
! !
@@ -137,10 +156,18 @@
#checkinReasonUIEnhancement
'Some enhancement in a UI which makes it look better or easier to use\(but does not add new functionality).\Please describe in detail what you did in the checkin info'
+#checkinReasonQuality
+'The change enhanced the quality of the product (debuggability, testability, robustness, etc.)\Typically used for test cases.'
+
+#checkinReasonTunng
+'The change enhances the performance.\Be epecially careful to always also add test cases,\because statistically, many errors are introduced by "optimizations".'
+
#checkinReasonOther
'Some other change, which does not fit into one of the above.\Please describe in detail what you did in the checkin info'
)
+
+ "Modified: / 31-03-2016 / 18:01:42 / cg"
! !
!CheckinInfoDialog class methodsFor:'interface specs'!
@@ -280,7 +307,7 @@
(LabelSpec
label: 'Reason for Checkin:'
name: 'Label6'
- layout: (AlignmentOrigin -126 0.5 -170 1 1 0.5)
+ layout: (LayoutOrigin 2 0 -179 1)
activeHelpKey: checkinReason
translateLabel: true
resizeForLabel: true
@@ -289,7 +316,7 @@
(RadioButtonSpec
label: 'Bugfix'
name: 'RadioButton1'
- layout: (LayoutFrame -123 0.5 -181 1 -126 1 -159 1)
+ layout: (LayoutFrame 20 0.0 -151 1 300 0 -129 1)
activeHelpKey: checkinReasonBugfix
translateLabel: true
model: checkinReasonHolder
@@ -299,7 +326,7 @@
(RadioButtonSpec
label: 'Feature / Enhancement'
name: 'RadioButton2'
- layout: (LayoutFrame -123 0.5 -157 1 -126 1 -135 1)
+ layout: (LayoutFrame -276 0.5 -127 1 -279 1 -105 1)
activeHelpKey: checkinReasonFeature
translateLabel: true
model: checkinReasonHolder
@@ -309,7 +336,7 @@
(RadioButtonSpec
label: 'Refactoring / Code Cleanup'
name: 'RadioButton3'
- layout: (LayoutFrame -123 0.5 -133 1 -126 1 -111 1)
+ layout: (LayoutFrame -276 0.5 -103 1 -279 1 -81 1)
activeHelpKey: checkinReasonRefactoring
translateLabel: true
model: checkinReasonHolder
@@ -319,7 +346,7 @@
(RadioButtonSpec
label: 'UI Enhancement / Beautification'
name: 'RadioButton6'
- layout: (LayoutFrame -123 0.5 -109 1 -126 1 -87 1)
+ layout: (LayoutFrame -276 0.5 -79 1 -279 1 -57 1)
activeHelpKey: checkinReasonUIEnhancement
translateLabel: true
model: checkinReasonHolder
@@ -329,7 +356,7 @@
(RadioButtonSpec
label: 'Documentation / Comment Only'
name: 'RadioButton5'
- layout: (LayoutFrame -123 0.5 -85 1 -126 1 -63 1)
+ layout: (LayoutFrame 9 0.5 -151 1 0 1 -129 1)
activeHelpKey: checkinReasonDocumentation
translateLabel: true
model: checkinReasonHolder
@@ -337,9 +364,29 @@
select: reasonDocumentation
)
(RadioButtonSpec
- label: 'None of the Above'
+ label: 'Tuning'
+ name: 'RadioButton4a'
+ layout: (LayoutFrame 9 0.5 -127 1 0 1 -105 1)
+ activeHelpKey: checkinReasonTuning
+ translateLabel: true
+ model: checkinReasonHolder
+ isTriggerOnDown: true
+ select: reasonTuning
+ )
+ (RadioButtonSpec
+ label: 'Quality (Debuggability / Testability('
name: 'RadioButton4'
- layout: (LayoutFrame -123 0.5 -61 1 -126 1 -39 1)
+ layout: (LayoutFrame 9 0.5 -103 1 0 1 -81 1)
+ activeHelpKey: checkinReasonQuality
+ translateLabel: true
+ model: checkinReasonHolder
+ isTriggerOnDown: true
+ select: reasonQuality
+ )
+ (RadioButtonSpec
+ label: 'None of the Above'
+ name: 'RadioButton7'
+ layout: (LayoutFrame 9 0.5 -79 1 0 1 -57 1)
activeHelpKey: checkinReasonOther
translateLabel: true
model: checkinReasonHolder
@@ -362,14 +409,14 @@
name: 'Button2'
translateLabel: true
model: doCancel
- extent: (Point 282 22)
+ extent: (Point 283 22)
)
(ActionButtonSpec
label: 'OK'
name: 'Button1'
translateLabel: true
model: doAccept
- extent: (Point 282 22)
+ extent: (Point 284 22)
)
)
@@ -513,8 +560,10 @@
!
checkinReason:aSymbolicReason
- self assert:( #(reasonBugfix reasonFeature reasonRefactoring reasonDocumentation reasonOther reasonUIEnhancement) includes:aSymbolicReason).
+ self assert:( self class possibleReasons includes:aSymbolicReason).
self checkinReasonHolder value:aSymbolicReason
+
+ "Modified: / 31-03-2016 / 17:58:45 / cg"
!
description