class: Tools::NewSystemBrowser
authorClaus Gittinger <cg@exept.de>
Mon, 16 Sep 2013 17:12:57 +0200
changeset 13555 11cfb7fdaee7
parent 13554 0c5bc183802b
child 13556 54e1ef230e31
class: Tools::NewSystemBrowser changed: #acceptMethod:inClass:language:check:
Tools__NewSystemBrowser.st
--- a/Tools__NewSystemBrowser.st	Mon Sep 16 12:40:45 2013 +0200
+++ b/Tools__NewSystemBrowser.st	Mon Sep 16 17:12:57 2013 +0200
@@ -56919,7 +56919,10 @@
     newSelector := self selectorOfMethodFromCode:code in:cls.
     existingMethod := cls compiledMethodAt:newSelector ifAbsent:[].
     cat := self protocolToAcceptMethod:newSelector class:cls.
-    cat isNil ifTrue:[^ false].
+    cat isNil ifTrue:[
+        self breakPoint:#cg.
+        ^ false
+    ].
 
     AbortOperationRequest catch:[
         (Class methodRedefinitionNotification) handle:[:ex |
@@ -56960,7 +56963,7 @@
 
 Accept anyway ?')
                 ifFalse:[
-                    ^ false
+                    self breakPoint:#cg. ^ false
                 ]
             ] ifFalse:[
                 "/ check if accepting a different selector than the selected one,
@@ -56991,10 +56994,10 @@
                                   default:false
                                   onCancel:false.
 
-                    answer == false ifTrue:[ ^ false ].
+                    answer == false ifTrue:[ self breakPoint:#cg. ^ false ].
                     answer == #compare ifTrue:[
                         self openDiffViewForText:code againstSourceOfMethod:existingMethod.
-                        ^ false
+                         self breakPoint:#cg. ^ false
                     ].
                 ]
             ].
@@ -57027,7 +57030,7 @@
                         package := self
                                         askForProject:'Method shall be assigned to which project ?'
                                         initialText:(LastAcceptPackage ? cls package).
-                        package isNil ifTrue:[^ false].
+                        package isNil ifTrue:[ self breakPoint:#cg. ^ false].
                         LastAcceptPackage := package.
                     ] ifFalse:[
                         package := package asSymbol.
@@ -57040,7 +57043,7 @@
                                                 askForProject:('The browsers selected project is ''%1''\however, your currently active (default) project is ''%2''.\\To which project shall the method be assigned ?'
                                                                bindWith:package allBold with:defPackage allBold) withCRs
                                                 initialText:package.
-                                package isNil ifTrue:[^ false].
+                                package isNil ifTrue:[ self breakPoint:#cg. ^ false].
                                 LastAcceptPackage := package.
                             ]
                         ]
@@ -57112,6 +57115,7 @@
                                 change controller:codeView.
                                 "/ change named:('Accept method ' , newSelector ? '???').
                                 Parser parseErrorSignal handle:[:ex |
+                                    Dialog information:ex description.
                                     rslt := nil
                                 ] do:[
                                     RefactoryChangeManager performChange: change.
@@ -57197,6 +57201,7 @@
             ].
         ]
     ].
+ self breakPoint:#cg. 
     ^ returnValue.
 
     "Created: / 30-12-2009 / 20:01:41 / Jan Vrany <jan.vrany@fit.cvut.cz>"
@@ -59170,11 +59175,11 @@
 !NewSystemBrowser class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libtool/Tools__NewSystemBrowser.st,v 1.1983 2013-09-13 13:41:28 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libtool/Tools__NewSystemBrowser.st,v 1.1984 2013-09-16 15:12:57 cg Exp $'
 !
 
 version_CVS
-    ^ '$Header: /cvs/stx/stx/libtool/Tools__NewSystemBrowser.st,v 1.1983 2013-09-13 13:41:28 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libtool/Tools__NewSystemBrowser.st,v 1.1984 2013-09-16 15:12:57 cg Exp $'
 !
 
 version_HG
@@ -59183,7 +59188,7 @@
 !
 
 version_SVN
-    ^ '$Id: Tools__NewSystemBrowser.st,v 1.1983 2013-09-13 13:41:28 cg Exp $'
+    ^ '$Id: Tools__NewSystemBrowser.st,v 1.1984 2013-09-16 15:12:57 cg Exp $'
 ! !