bumped update to e5ebfa0097d1: jv
authorJan Vrany <jan.vrany@fit.cvut.cz>
Fri, 17 Nov 2017 12:27:21 -0300
branchjv
changeset 17851 171883b798be
parent 17766 e5ebfa0097d1
child 17854 5b714db88667
bumped update to e5ebfa0097d1: Mini / Embedded test runner: show number of skipped tests in report Previusly, skipped tests were simply ignored which was confusing. Thanks Guillermo for pushing me to fix this.
Tools__TestRunnerMini.st
--- a/Tools__TestRunnerMini.st	Fri Nov 17 12:27:21 2017 -0300
+++ b/Tools__TestRunnerMini.st	Fri Nov 17 12:27:21 2017 -0300
@@ -1226,30 +1226,22 @@
 !TestRunnerMini::SuiteAndResult methodsFor:'accessing'!
 
 color
-    |numTests numRun|
-
     self testCount > 0 ifTrue:[
         result notNil ifTrue:[
             self hasErrors ifTrue:[^AbstractTestRunner errorColor].
             self hasFailures ifTrue:[^AbstractTestRunner failedColor].
-            self hasSkipped ifTrue:[^AbstractTestRunner notRunColor]. 
-            self hasPassed ifTrue:[
-                numTests := suite tests size.
-                numRun := result passedCount + result failureCount + result errorCount.
-                numRun = numTests ifTrue:[
-                    ^AbstractTestRunner passedColor 
-                ]
-            ].
+            self hasPassed ifTrue:[^AbstractTestRunner passedColor].
+            self hasSkipped ifTrue:[^AbstractTestRunner notRunColor].
         ]
     ].
     ^ AbstractTestRunner notRunColor
 
     "Created: / 15-03-2010 / 15:24:35 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 23-09-2014 / 10:04:52 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 27-11-2017 / 21:17:14 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 info
-    |numTests numPassed numFailed numRun resources numError numSkipped |
+    |numTests numPassed numFailed numRun resources numError |
 
     result isNil ifTrue:[^''].
 
@@ -1257,8 +1249,7 @@
     numPassed := result passedCount.
     numFailed := result failureCount.
     numError := result errorCount.
-    numSkipped := result skippedCount.
-    numRun := numPassed + numFailed + numError + numSkipped.
+    numRun := numPassed + numFailed + numError.
     "/ (result passedCount + result failureCount + result errorCount) = 1 ifTrue:[^''].
     resources := TestRunnerMini resources.
     numRun == 0 ifTrue:[
@@ -1286,14 +1277,10 @@
             "/ ', %5 errors'...
             s nextPut: $,. numError printOn: s. s space; nextPutAll: (resources string: (numError > 1 ifTrue:[ 'errors' ] ifFalse:[ 'error' ])).
         ].
-        numSkipped > 0 ifTrue:[ 
-            "/ ', %4 failed'...
-            s nextPut: $,. numSkipped printOn: s. s space; nextPutAll: (resources string: 'skipped').
-        ].
     ].
 
     "Created: / 15-03-2010 / 20:23:34 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 17-11-2017 / 12:25:11 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 17-11-2017 / 12:23:40 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 name