#REFACTORING by cg
authorClaus Gittinger <cg@exept.de>
Wed, 09 Aug 2017 10:39:38 +0200
changeset 17614 1e76bd2f0d4e
parent 17613 fa86097606d3
child 17615 3e309e07c22a
#REFACTORING by cg class: Tools::NewSystemBrowser changed: #showMessageWhileTest #smalllintRunRule:onEnvironment: code simplified
Tools__NewSystemBrowser.st
--- a/Tools__NewSystemBrowser.st	Tue Aug 08 16:32:46 2017 +0200
+++ b/Tools__NewSystemBrowser.st	Wed Aug 09 10:39:38 2017 +0200
@@ -1,5 +1,3 @@
-"{ Encoding: utf8 }"
-
 "
  COPYRIGHT (c) 2000 by eXept Software AG
               All Rights Reserved
@@ -29362,10 +29360,9 @@
             "/ value  
             benchmark:(rule name,': ')
     ].
-    ProgressNotification new
-        messageText: ('Done');
-        parameter: 100;
-        raiseRequest.
+    ProgressNotification 
+        raiseRequestWith:100
+        errorString:'Done'.
 
     aBrowserEnvironment forgetCachedClasses.
 
@@ -29375,7 +29372,7 @@
     "Created: / 28-08-2010 / 12:12:51 / Jan Vrany <jan.vrany@fit.cvut.cz>"
     "Modified: / 14-10-2014 / 18:01:37 / Jan Vrany <jan.vrany@fit.cvut.cz>"
     "Modified (comment): / 27-11-2014 / 11:38:51 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 19-11-2016 / 20:16:53 / cg"
+    "Modified: / 09-08-2017 / 10:35:54 / cg"
 !
 
 smalllintRunSelectedOnEnvironment:aBrowserEnvironment
@@ -47706,7 +47703,7 @@
 
         self activityNotification:nil.
         browser := (UserPreferences current changeSetBrowserClass) openOn:previousMethods.
-        browser window label:(resources string:'Revisions of %1 » %2' with:mclass name with:mselector).
+        browser window label:(resources string:'Revisions of %1 » %2' with:mclass name with:mselector).
         browser readOnly:true.
     ].
 
@@ -52321,7 +52318,7 @@
             label:[:chg | 
                 |lbl|
                 "/ lbl := chg printString
-                lbl := (chg className ? '???') , ' » ' , (chg selector  ? '???') allBold.
+                lbl := (chg className ? '???') , ' » ' , (chg selector  ? '???') allBold.
                 (chg isMethodChange and:[chg changeMethod isNil]) ifTrue:[
                     lbl := lbl asText allStrikedOut,' ','(removed)' allItalic.
                 ].    
@@ -59820,6 +59817,7 @@
     ^ selectorCompletion
 ! !
 
+
 !NewSystemBrowser methodsFor:'private-semantic checks'!
 
 checkAcceptedMethod:aMethod inClass:aClass
@@ -63900,11 +63898,6 @@
 !
 
 showMessageWhileTest
-    | b |
-
-    b :=
-
-
     self
         showMessage:'Tools::NewSystemBrowser >> testProgressAction'
         whileExecutingBackgroundAction:[
@@ -63912,11 +63905,9 @@
 
             i := 1.
             [ i <= 100] whileTrue:[
-                (ProgressNotification new)
-                    messageText:('Tools::NewSystemBrowser >> testProgressAction (%1 done)'
-                                bindWith:i);
-                    parameter:i;
-                    raiseRequest.
+                ProgressNotification 
+                    raiseRequestWith:i
+                    errorString:('Tools::NewSystemBrowser >> testProgressAction (%1 done)' bindWith:i).
                 Delay waitForMilliseconds:30.
                 i := i + 1.
             ].
@@ -63924,12 +63915,12 @@
         ]
 
     "
-        WindowGroup activeApplication showMessageWhileTest
+     WindowGroup activeApplication showMessageWhileTest
     "
 
     "Created: / 28-08-2010 / 10:32:08 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 15-05-2012 / 10:46:06 / cg"
     "Modified (comment): / 25-03-2014 / 18:15:15 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified (comment): / 09-08-2017 / 10:35:19 / cg"
 ! !
 
 !NewSystemBrowser methodsFor:'user actions-profiler'!