#TUNING by cg
authorClaus Gittinger <cg@exept.de>
Sun, 19 Nov 2017 15:04:02 +0100
changeset 17770 2555e5410582
parent 17769 156241c3adef
child 17771 0079b02e0f34
#TUNING by cg class: Tools::CodeView2::TextView comment/format in: #list:expandTabs:scanForNonStrings:includesNonStrings: changed: #updateReallyModified no need to compare if the text is not writable
Tools__CodeView2.st
--- a/Tools__CodeView2.st	Sun Nov 19 15:02:45 2017 +0100
+++ b/Tools__CodeView2.st	Sun Nov 19 15:04:02 2017 +0100
@@ -3357,10 +3357,15 @@
     "/    leaves suppressNotifications to true, which is not what
     "/    we want!!
     self updateReallyModified.
+    
+    "/ sorry Jan, but your code is very misleading here;
+    "/ you are not remembering any modifications, but instead just forcing a redraw;
+    "/ so why not calling it as such????
     codeView linesModifiedFrom: 1 to: list size.
 
     "Created: / 08-10-2011 / 12:23:52 / Jan Vrany <jan.vrany@fit.cvut.cz>"
     "Modified (comment): / 03-08-2013 / 13:35:39 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified (comment): / 19-11-2017 / 14:17:48 / cg"
 !
 
 setList:aCollection expandTabs:expandTabs redraw:doRedraw
@@ -4247,15 +4252,16 @@
      interested. Not sure if it is a good idea, thought."
     reallyModifiedChannel dependents isEmptyOrNil ifTrue:[^self].
 
-    "/ higher prio to prevent it from being changed while we convert it (by editing)
-
-    modified := self isTextDifferentFromOriginalSource.
-
+    readOnly ifTrue:[
+        modified := false
+    ] ifFalse:[
+        modified := self isTextDifferentFromOriginalSource.
+    ].
     reallyModifiedChannel value: modified
 
     "Created: / 07-10-2011 / 19:16:25 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 08-10-2011 / 11:10:01 / cg"
     "Modified: / 28-10-2011 / 09:23:01 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 19-11-2017 / 14:18:55 / cg"
 ! !
 
 !CodeView2::TextView methodsFor:'queries'!