#UI_ENHANCEMENT by cg
authorClaus Gittinger <cg@exept.de>
Wed, 13 Mar 2019 10:49:21 +0100
changeset 18674 53730b0e2bee
parent 18673 87beb311e63a
child 18675 f7d7084c61cc
#UI_ENHANCEMENT by cg class: VersionDiffBrowser comment/format in: #methodsChangedSelectionChanged #showVersionInfoIfNothingSelected changed: #methodsOnlyInASelectionChanged #methodsOnlyInBSelectionChanged
VersionDiffBrowser.st
--- a/VersionDiffBrowser.st	Tue Mar 12 23:15:52 2019 +0100
+++ b/VersionDiffBrowser.st	Wed Mar 13 10:49:21 2019 +0100
@@ -2118,13 +2118,11 @@
 !
 
 methodsChangedSelectionChanged
-    "
-    the selection in the list of the 'changed methods' changed.
-    Reset the selection of the two other lists and calc the method change.
-
-    <return: self>
-    "
-    |sel changeA changeB methodsChanged parseError treeA treeB|
+    "the selection in the list of the 'changed methods' changed.
+     Reset the selection of the two other lists and calc the method change.
+     <return: self>"
+
+    |sel changeA changeB methodsChanged|
 
     "/ self information:''.
 
@@ -2155,17 +2153,16 @@
     "Modified: / 03-09-1999 / 15:01:30 / ps"
     "Modified: / 29-11-2017 / 12:56:28 / cg"
     "Modified: / 23-07-2018 / 09:51:12 / Claus Gittinger"
+    "Modified (format): / 13-03-2019 / 10:39:33 / Claus Gittinger"
 !
 
 methodsOnlyInASelectionChanged
-    "
-    the selection in the list of the 'method only in version A' changed.
-    Reset the selection of the two other lists and show the method in
-    the text view.
-
-    <return: self>
-    "
-    |change sel|
+    "the selection in the list of the 'method only in version A' changed.
+     Reset the selection of the two other lists and show the method in
+     the text view.
+     <return: self>"
+
+    |change sel versionA|
 
     "/ self information:''.
 
@@ -2176,22 +2173,24 @@
         change := methodsOnlyInAFiltered "self changeSetA" at:sel.
         self methodText value:(change prettyPrintedSource).
         self showSingleTextView.
+        (versionA := diffTextLabelA value) notEmptyOrNil ifTrue:[
+            self infoHolder value:('Method removed from version: ',versionA).
+        ].    
     ] ifFalse:[
         self showVersionInfoIfNothingSelected
     ].
 
     "Modified: / 05-02-2017 / 12:08:07 / cg"
+    "Modified: / 13-03-2019 / 10:48:17 / Claus Gittinger"
 !
 
 methodsOnlyInBSelectionChanged
-    "
-    the selection in the list of the 'method only in version B' changed.
-    Reset the selection of the two other lists and show the method in
-    the text view.
-
-    <return: self>
-    "
-    |change sel|
+    "the selection in the list of the 'method only in version B' changed.
+     Reset the selection of the two other lists and show the method in
+     the text view.
+     <return: self>"
+
+    |change sel versionA|
 
     "/ self information:''.
 
@@ -2202,11 +2201,15 @@
         change := methodsOnlyInBFiltered "self changeSetB" at:sel.
         self methodText value:(change prettyPrintedSource).
         self showSingleTextView.
+        (versionA := diffTextLabelA value) notEmptyOrNil ifTrue:[
+            self infoHolder value:('Method added to version: ',versionA).
+        ].    
     ] ifFalse:[
         self showVersionInfoIfNothingSelected
     ].
 
     "Modified: / 05-02-2017 / 11:49:22 / cg"
+    "Modified: / 13-03-2019 / 10:48:23 / Claus Gittinger"
 !
 
 selectedSymbolicVersionHolderChanged
@@ -3618,7 +3621,8 @@
 !
 
 showVersionInfoIfNothingSelected
-    "show the revision info (author, date, time and logMessage), if no method is selected"
+    "show the revision info (author, date, time and logMessage), 
+     if no method is selected"
 
     |revInfo infoText|
 
@@ -3643,6 +3647,7 @@
     ].
 
     "Modified: / 05-02-2017 / 11:49:47 / cg"
+    "Modified (comment): / 13-03-2019 / 10:41:01 / Claus Gittinger"
 ! !
 
 !VersionDiffBrowser methodsFor:'setup'!