#UI_ENHANCEMENT by cg
authorClaus Gittinger <cg@exept.de>
Fri, 14 Oct 2016 02:59:05 +0200
changeset 16952 77ac8d172149
parent 16951 cfb02675deb2
child 16953 9ad8c3d47cf2
#UI_ENHANCEMENT by cg class: Tools::NewSystemBrowser changed: #showInfo: care for showMarqueeInfo userpref settings. (no info scrolling then)
Tools__NewSystemBrowser.st
--- a/Tools__NewSystemBrowser.st	Fri Oct 14 02:50:56 2016 +0200
+++ b/Tools__NewSystemBrowser.st	Fri Oct 14 02:59:05 2016 +0200
@@ -1,5 +1,3 @@
-"{ Encoding: utf8 }"
-
 "
  COPYRIGHT (c) 2000 by eXept Software AG
               All Rights Reserved
@@ -16,61 +14,61 @@
 "{ NameSpace: Tools }"
 
 SystemBrowser subclass:#NewSystemBrowser
-        instanceVariableNames:'environmentHolder environment navigationState bufferNameList
-                selectedBuffer buffers bufferUsageOrder browserCanvas
-                immediateUpdate showClassPackages lastMethodCategory
-                lastMethodMoveClass browserCanvasType
-                syntaxColoringProcessRunning syntaxColoringProcess
-                methodInfoProcess browsletShowHideLabelHolder browserPageCanvas
-                isEmbedded hasNonEmptyEnvironmentSelectedHolder
-                smalllintRulesOrAllHolder smalllintRulesOrDefaultHolder
-                explainProcess'
-        classVariableNames:'LastNewProtocols LastProtocolRenames LastCategoryRenames
-                LastCategoryRenameOld LastCategoryRenameNew LastProjectMoves
-                LastNameSpaceMove LastMethodMoveOrCopyTargetClass
-                LastClassFilterBlockString LastMethodFilterBlockString
-                LastBreakPointConditionString LastIndividualChecks
-                LastAcceptPackage LastVariableRenames LastVisitorClassName
-                LastTemporaryVariableName FindHistory SynchronousUpdate
-                DoubleClickIsOpenBrowser ShowMethodTemplateWhenProtocolIsSelected
-                DefaultShowMethodInheritance DefaultEmphasizeUnloadedClasses
-                DefaultImmediateSyntaxColoring DefaultImmediateExplaining
-                DefaultSyntaxColoring DefaultToolBarVisible
-                DefaultCodeInfoVisible DefaultShortNameInTabs
-                DefaultHideUnloadedClasses DefaultMarkApplications
-                DefaultAutoFormat DefaultShowMethodComplexity
-                DefaultShowMethodTypeIcon DefaultShowSpecialResourceEditors
-                DefaultShowSyntheticMethods SharedMethodCategoryCache
-                LastMethodProcessingBlockString LastLoadedPackages
-                DefaultShortAllClassesInNameSpaceOrganisation LastBaseVersionTag
-                LastTag DefaultShowPseudoProtocols DefaultShowMultitabMode
-                LastRenamedOld LastRenamedNew LastImportedPackage
-                LastLintRulesHolder NewNavigationHistory
-                LastLiteralReplacementType LastLiteralReplacementNewName
-                LastLiteralReplacementOldLiteral LastNewProjectType
-                LastClassProcessingBlockString RecentlyClosedList
-                LastClassSearchBoxShowedFullName CachedTagToRevisionMapping
-                CachedMethodsImplemented LastCypressDirectory
-                LastClassSearchBoxShowedJavaOnly LastRemoteRepository
-                LastClassDocDirectory DefaultShowCoverage LastLintedPackage
-                LastSearchedImplementors LastSearchedSenders
-                LastComparedClassName'
-        poolDictionaries:''
-        category:'Interface-Browsers-New'
+	instanceVariableNames:'environmentHolder environment navigationState bufferNameList
+		selectedBuffer buffers bufferUsageOrder browserCanvas
+		immediateUpdate showClassPackages lastMethodCategory
+		lastMethodMoveClass browserCanvasType
+		syntaxColoringProcessRunning syntaxColoringProcess
+		methodInfoProcess browsletShowHideLabelHolder browserPageCanvas
+		isEmbedded hasNonEmptyEnvironmentSelectedHolder
+		smalllintRulesOrAllHolder smalllintRulesOrDefaultHolder
+		explainProcess'
+	classVariableNames:'LastNewProtocols LastProtocolRenames LastCategoryRenames
+		LastCategoryRenameOld LastCategoryRenameNew LastProjectMoves
+		LastNameSpaceMove LastMethodMoveOrCopyTargetClass
+		LastClassFilterBlockString LastMethodFilterBlockString
+		LastBreakPointConditionString LastIndividualChecks
+		LastAcceptPackage LastVariableRenames LastVisitorClassName
+		LastTemporaryVariableName FindHistory SynchronousUpdate
+		DoubleClickIsOpenBrowser ShowMethodTemplateWhenProtocolIsSelected
+		DefaultShowMethodInheritance DefaultEmphasizeUnloadedClasses
+		DefaultImmediateSyntaxColoring DefaultImmediateExplaining
+		DefaultSyntaxColoring DefaultToolBarVisible
+		DefaultCodeInfoVisible DefaultShortNameInTabs
+		DefaultHideUnloadedClasses DefaultMarkApplications
+		DefaultAutoFormat DefaultShowMethodComplexity
+		DefaultShowMethodTypeIcon DefaultShowSpecialResourceEditors
+		DefaultShowSyntheticMethods SharedMethodCategoryCache
+		LastMethodProcessingBlockString LastLoadedPackages
+		DefaultShortAllClassesInNameSpaceOrganisation LastBaseVersionTag
+		LastTag DefaultShowPseudoProtocols DefaultShowMultitabMode
+		LastRenamedOld LastRenamedNew LastImportedPackage
+		LastLintRulesHolder NewNavigationHistory
+		LastLiteralReplacementType LastLiteralReplacementNewName
+		LastLiteralReplacementOldLiteral LastNewProjectType
+		LastClassProcessingBlockString RecentlyClosedList
+		LastClassSearchBoxShowedFullName CachedTagToRevisionMapping
+		CachedMethodsImplemented LastCypressDirectory
+		LastClassSearchBoxShowedJavaOnly LastRemoteRepository
+		LastClassDocDirectory DefaultShowCoverage LastLintedPackage
+		LastSearchedImplementors LastSearchedSenders
+		LastComparedClassName'
+	poolDictionaries:''
+	category:'Interface-Browsers-New'
 !
 
 ListEntry subclass:#OwnershipGraph
-        instanceVariableNames:'ownershipInfo cachedForm'
-        classVariableNames:''
-        poolDictionaries:''
-        privateIn:NewSystemBrowser
+	instanceVariableNames:'ownershipInfo cachedForm'
+	classVariableNames:''
+	poolDictionaries:''
+	privateIn:NewSystemBrowser
 !
 
 Object subclass:#RevisionOwnershipInfo
-        instanceVariableNames:'revision author date lineOwnership'
-        classVariableNames:''
-        poolDictionaries:''
-        privateIn:NewSystemBrowser::OwnershipGraph
+	instanceVariableNames:'revision author date lineOwnership'
+	classVariableNames:''
+	poolDictionaries:''
+	privateIn:NewSystemBrowser::OwnershipGraph
 !
 
 !NewSystemBrowser class methodsFor:'documentation'!
@@ -46988,7 +46986,7 @@
 
         self activityNotification:nil.
         browser := (UserPreferences current changeSetBrowserClass) openOn:previousMethods.
-        browser window label:(resources string:'Revisions of %1 » %2' with:mclass name with:mselector).
+        browser window label:(resources string:'Revisions of %1 » %2' with:mclass name with:mselector).
         browser readOnly:true.
     ].
 
@@ -51573,7 +51571,7 @@
             label:[:chg | 
                 |lbl|
                 "/ lbl := chg printString
-                lbl := (chg className ? '???') , ' » ' , (chg selector  ? '???') allBold.
+                lbl := (chg className ? '???') , ' » ' , (chg selector  ? '???') allBold.
                 (chg isMethodChange and:[chg changeMethod isNil]) ifTrue:[
                     lbl := lbl asText allStrikedOut,' ','(removed)' allItalic.
                 ].    
@@ -58738,13 +58736,17 @@
     self navigationState showingParseError:false.
     (messageShown := msg) notNil ifTrue:[
         messageShown := msg asStringCollection "asStringWithoutFinalCR".
-        messageShown size == 1 ifTrue:[
+        messageShown size <= 1 ifTrue:[
             messageShown := msg.
         ] ifFalse:[
-            doAnimate := true.
-            "/ messageShown do:[:eachLine|
-            "/     Transcript show:' > '; showCR:eachLine; showCR:'"'.
-            "/].    
+            UserPreferences current showMarqueeInfo ifFalse:[
+                messageShown := messageShown first
+            ] ifTrue:[                    
+                doAnimate := true.
+                "/ messageShown do:[:eachLine|
+                "/     Transcript show:' > '; showCR:eachLine; showCR:'"'.
+                "/].    
+            ].
         ].    
     ].
     self infoLabelHolder value:messageShown.
@@ -58927,6 +58929,7 @@
     ^ selectorCompletion
 ! !
 
+
 !NewSystemBrowser methodsFor:'private-semantic checks'!
 
 checkAcceptedMethod:aMethod inClass:aClass