#selection: now does a notification / #setSelection: does not
authorClaus Gittinger <cg@exept.de>
Sat, 25 May 1996 13:27:40 +0200
changeset 562 8f772068fd1a
parent 561 a2e208a1f0d2
child 563 93633e3ff304
#selection: now does a notification / #setSelection: does not
CBrowser.st
ChangesBrowser.st
--- a/CBrowser.st	Sat May 25 13:25:20 1996 +0200
+++ b/CBrowser.st	Sat May 25 13:27:40 1996 +0200
@@ -577,14 +577,16 @@
     "select a change"
 
     self class autoSelectNext ifTrue:[
-	(changeNr <= self numberOfChanges) ifTrue:[
-	    changeListView selection:changeNr.
-	    self changeSelection:changeNr.
-	    ^ self
-	]
+        (changeNr <= self numberOfChanges) ifTrue:[
+            changeListView setSelection:changeNr.
+            self changeSelection:changeNr.
+            ^ self
+        ]
     ].
     self clearCodeView.
-    changeListView selection:nil.
+    changeListView setSelection:nil.
+
+    "Modified: 25.5.1996 / 12:28:21 / cg"
 !
 
 autoSelectLast
@@ -600,11 +602,13 @@
 
     last := self numberOfChanges.
     changeNr < last ifTrue:[
-	self autoSelect:changeNr
+        self autoSelect:changeNr
     ] ifFalse:[
-	changeListView selection:last .
-	self changeSelection:last.
+        changeListView setSelection:last .
+        self changeSelection:last.
     ]
+
+    "Modified: 25.5.1996 / 12:26:17 / cg"
 !
 
 changeFileName:aFileName
@@ -844,12 +848,13 @@
 deleteChangesFrom:start to:stop
     "delete a range of changes"
 
-    changeListView deselect.
+    changeListView setSelection:nil.
     stop to:start by:-1 do:[:changeNr |
-	self silentDeleteChange:changeNr
+        self silentDeleteChange:changeNr
     ].
-    self setChangeList 
+    self setChangeList
 
+    "Modified: 25.5.1996 / 13:02:46 / cg"
 !
 
 fullClassNameOfChange:changeNr
@@ -1468,7 +1473,9 @@
 unselect
     "common unselect"
 
-    changeListView deselect.
+    changeListView setSelection:nil.
+
+    "Modified: 25.5.1996 / 13:02:49 / cg"
 !
 
 withSelectedChangeDo:aBlock
@@ -1649,50 +1656,54 @@
         self clearCodeView.
         skipSignal isNil ifTrue:[skipSignal := Signal new].
         1 to:(self numberOfChanges) do:[:changeNr |
-            changeListView selection:changeNr.
+            changeListView setSelection:changeNr.
             self applyChange:changeNr
         ].
         self autoSelectLast
     ]
 
-    "Modified: 14.12.1995 / 20:58:03 / cg"
+    "Modified: 25.5.1996 / 12:26:20 / cg"
 !
 
 doApplyClassRest
     "user wants all changes for this class from changeNr to be applied"
 
     self withSelectedChangeDo:[:changeNr |
-	|thisClassName classNameToApply lastChange|
+        |thisClassName classNameToApply lastChange|
 
-	classNameToApply := self classNameOfChange:changeNr.
-	classNameToApply notNil ifTrue:[
-	    self clearCodeView.
-	    skipSignal isNil ifTrue:[skipSignal := Signal new].
-	    changeNr to:(self numberOfChanges) do:[:changeNr |
-		thisClassName := self classNameOfChange:changeNr.
-		thisClassName = classNameToApply ifTrue:[
-		    changeListView selection:changeNr.
-		    self applyChange:changeNr.
-		    lastChange := changeNr
-		].
-	    ].
-	    self autoSelect:lastChange.
-	]
+        classNameToApply := self classNameOfChange:changeNr.
+        classNameToApply notNil ifTrue:[
+            self clearCodeView.
+            skipSignal isNil ifTrue:[skipSignal := Signal new].
+            changeNr to:(self numberOfChanges) do:[:changeNr |
+                thisClassName := self classNameOfChange:changeNr.
+                thisClassName = classNameToApply ifTrue:[
+                    changeListView setSelection:changeNr.
+                    self applyChange:changeNr.
+                    lastChange := changeNr
+                ].
+            ].
+            self autoSelect:lastChange.
+        ]
     ]
+
+    "Modified: 25.5.1996 / 12:26:25 / cg"
 !
 
 doApplyRest
     "user wants all changes from changeNr to be applied"
 
     self withSelectedChangeDo:[:changeNr |
-	self clearCodeView.
-	skipSignal isNil ifTrue:[skipSignal := Signal new].
-	changeNr to:(self numberOfChanges) do:[:changeNr |
-	    changeListView selection:changeNr.
-	    self applyChange:changeNr
-	].
-	self autoSelect:self numberOfChanges.
+        self clearCodeView.
+        skipSignal isNil ifTrue:[skipSignal := Signal new].
+        changeNr to:(self numberOfChanges) do:[:changeNr |
+            changeListView setSelection:changeNr.
+            self applyChange:changeNr
+        ].
+        self autoSelect:self numberOfChanges.
     ]
+
+    "Modified: 25.5.1996 / 12:26:28 / cg"
 !
 
 doBrowse
@@ -1868,7 +1879,7 @@
         "finally delete what has been found"
 
         (deleteSet size > 0) ifTrue:[
-            changeListView deselect.
+            changeListView setSelection:nil.
             index := deleteSet size.
             [index > 0] whileTrue:[
                 self silentDeleteChange:(deleteSet at:index).
@@ -1887,7 +1898,7 @@
     self newLabel:''.
 
     "Created: 3.12.1995 / 14:29:54 / cg"
-    "Modified: 14.12.1995 / 20:58:22 / cg"
+    "Modified: 25.5.1996 / 13:02:47 / cg"
 !
 
 doDelete
@@ -1906,20 +1917,21 @@
     "delete all changes with same class as currently selected change"
 
     self withSelectedChangeDo:[:changeNr |
-	| classNameToDelete |
+        | classNameToDelete |
 
-	classNameToDelete := self classNameOfChange:changeNr.
-	classNameToDelete notNil ifTrue:[
-	    changeListView selection:nil.
-	    self silentDeleteChangesFor:classNameToDelete
-				   from:1
-				     to:(self numberOfChanges).
-	    self setChangeList. 
-	    self autoSelectOrEnd:changeNr
-	]
+        classNameToDelete := self classNameOfChange:changeNr.
+        classNameToDelete notNil ifTrue:[
+            changeListView setSelection:nil.
+            self silentDeleteChangesFor:classNameToDelete
+                                   from:1
+                                     to:(self numberOfChanges).
+            self setChangeList. 
+            self autoSelectOrEnd:changeNr
+        ]
     ]
 
     "Created: 13.12.1995 / 16:07:14 / cg"
+    "Modified: 25.5.1996 / 12:26:31 / cg"
 !
 
 doDeleteClassFromBeginning
@@ -1932,7 +1944,7 @@
 
         classNameToDelete := self classNameOfChange:changeNr.
         classNameToDelete notNil ifTrue:[
-            changeListView selection:nil.
+            changeListView setSelection:nil.
             self silentDeleteChangesFor:classNameToDelete 
                                    from:1 
                                      to:changeNr.
@@ -1942,25 +1954,27 @@
     ]
 
     "Created: 13.12.1995 / 15:41:58 / cg"
-    "Modified: 13.12.1995 / 15:43:20 / cg"
+    "Modified: 25.5.1996 / 12:26:34 / cg"
 !
 
 doDeleteClassRest
     "delete rest of changes with same class as currently selected change"
 
     self withSelectedChangeDo:[:changeNr |
-	| classNameToDelete |
+        | classNameToDelete |
 
-	classNameToDelete := self classNameOfChange:changeNr.
-	classNameToDelete notNil ifTrue:[
-	    changeListView selection:nil.
-	    self silentDeleteChangesFor:classNameToDelete 
-				   from:changeNr
-				     to:(self numberOfChanges).
-	    self setChangeList.
-	    self autoSelectOrEnd:changeNr
-	]
+        classNameToDelete := self classNameOfChange:changeNr.
+        classNameToDelete notNil ifTrue:[
+            changeListView setSelection:nil.
+            self silentDeleteChangesFor:classNameToDelete 
+                                   from:changeNr
+                                     to:(self numberOfChanges).
+            self setChangeList.
+            self autoSelectOrEnd:changeNr
+        ]
     ]
+
+    "Modified: 25.5.1996 / 12:26:39 / cg"
 !
 
 doDeleteRest
@@ -2102,24 +2116,26 @@
 
     changeNr := changeListView selection.
     changeNr notNil ifTrue:[
-	fileName := Dialog
-			requestFileName:'append changes to:'
-			default:''
-			ok:'append'
-			abort:'abort'
-			pattern:'*.chg'.
+        fileName := Dialog
+                        requestFileName:'append changes to:'
+                        default:''
+                        ok:'append'
+                        abort:'abort'
+                        pattern:'*.chg'.
 
-	fileName notNil ifTrue:[
-	    self withCursor:(Cursor write) do:[
-		changeNr to:(self numberOfChanges) do:[:changeNr |
-		    changeListView selection:changeNr.
-		    (self appendChange:changeNr toFile:fileName) ifFalse:[
-			^ self
-		    ]
-		]
-	    ]
-	].
+        fileName notNil ifTrue:[
+            self withCursor:(Cursor write) do:[
+                changeNr to:(self numberOfChanges) do:[:changeNr |
+                    changeListView setSelection:changeNr.
+                    (self appendChange:changeNr toFile:fileName) ifFalse:[
+                        ^ self
+                    ]
+                ]
+            ]
+        ].
     ]
+
+    "Modified: 25.5.1996 / 12:26:41 / cg"
 !
 
 doUpdate
@@ -2159,33 +2175,35 @@
 
     changeNr := changeListView selection.
     changeNr notNil ifTrue:[
-	fileName := Dialog
-			requestFileName:'append changes for class to:'
-			default:''
-			ok:'append'
-			abort:'abort'
-			pattern:'*.chg'.
+        fileName := Dialog
+                        requestFileName:'append changes for class to:'
+                        default:''
+                        ok:'append'
+                        abort:'abort'
+                        pattern:'*.chg'.
 
-	fileName notNil ifTrue:[
-	    self withCursor:(Cursor write) do:[
-		startNr to:(self numberOfChanges) do:[:changeNr |
-		    |thisClassName|
+        fileName notNil ifTrue:[
+            self withCursor:(Cursor write) do:[
+                startNr to:(self numberOfChanges) do:[:changeNr |
+                    |thisClassName|
 
-		    thisClassName := self classNameOfChange:changeNr.
-		    thisClassName = aClassName ifTrue:[
-			changeListView selection:changeNr.
-			(self appendChange:changeNr toFile:fileName) ifFalse:[
-			    ^ self
-			]
-		    ]
-		]
-	    ]
-	].
+                    thisClassName := self classNameOfChange:changeNr.
+                    thisClassName = aClassName ifTrue:[
+                        changeListView setSelection:changeNr.
+                        (self appendChange:changeNr toFile:fileName) ifFalse:[
+                            ^ self
+                        ]
+                    ]
+                ]
+            ]
+        ].
     ]
+
+    "Modified: 25.5.1996 / 12:26:44 / cg"
 ! !
 
 !ChangesBrowser class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libtool/Attic/CBrowser.st,v 1.80 1996-05-18 15:46:10 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libtool/Attic/CBrowser.st,v 1.81 1996-05-25 11:27:40 cg Exp $'
 ! !
--- a/ChangesBrowser.st	Sat May 25 13:25:20 1996 +0200
+++ b/ChangesBrowser.st	Sat May 25 13:27:40 1996 +0200
@@ -577,14 +577,16 @@
     "select a change"
 
     self class autoSelectNext ifTrue:[
-	(changeNr <= self numberOfChanges) ifTrue:[
-	    changeListView selection:changeNr.
-	    self changeSelection:changeNr.
-	    ^ self
-	]
+        (changeNr <= self numberOfChanges) ifTrue:[
+            changeListView setSelection:changeNr.
+            self changeSelection:changeNr.
+            ^ self
+        ]
     ].
     self clearCodeView.
-    changeListView selection:nil.
+    changeListView setSelection:nil.
+
+    "Modified: 25.5.1996 / 12:28:21 / cg"
 !
 
 autoSelectLast
@@ -600,11 +602,13 @@
 
     last := self numberOfChanges.
     changeNr < last ifTrue:[
-	self autoSelect:changeNr
+        self autoSelect:changeNr
     ] ifFalse:[
-	changeListView selection:last .
-	self changeSelection:last.
+        changeListView setSelection:last .
+        self changeSelection:last.
     ]
+
+    "Modified: 25.5.1996 / 12:26:17 / cg"
 !
 
 changeFileName:aFileName
@@ -844,12 +848,13 @@
 deleteChangesFrom:start to:stop
     "delete a range of changes"
 
-    changeListView deselect.
+    changeListView setSelection:nil.
     stop to:start by:-1 do:[:changeNr |
-	self silentDeleteChange:changeNr
+        self silentDeleteChange:changeNr
     ].
-    self setChangeList 
+    self setChangeList
 
+    "Modified: 25.5.1996 / 13:02:46 / cg"
 !
 
 fullClassNameOfChange:changeNr
@@ -1468,7 +1473,9 @@
 unselect
     "common unselect"
 
-    changeListView deselect.
+    changeListView setSelection:nil.
+
+    "Modified: 25.5.1996 / 13:02:49 / cg"
 !
 
 withSelectedChangeDo:aBlock
@@ -1649,50 +1656,54 @@
         self clearCodeView.
         skipSignal isNil ifTrue:[skipSignal := Signal new].
         1 to:(self numberOfChanges) do:[:changeNr |
-            changeListView selection:changeNr.
+            changeListView setSelection:changeNr.
             self applyChange:changeNr
         ].
         self autoSelectLast
     ]
 
-    "Modified: 14.12.1995 / 20:58:03 / cg"
+    "Modified: 25.5.1996 / 12:26:20 / cg"
 !
 
 doApplyClassRest
     "user wants all changes for this class from changeNr to be applied"
 
     self withSelectedChangeDo:[:changeNr |
-	|thisClassName classNameToApply lastChange|
+        |thisClassName classNameToApply lastChange|
 
-	classNameToApply := self classNameOfChange:changeNr.
-	classNameToApply notNil ifTrue:[
-	    self clearCodeView.
-	    skipSignal isNil ifTrue:[skipSignal := Signal new].
-	    changeNr to:(self numberOfChanges) do:[:changeNr |
-		thisClassName := self classNameOfChange:changeNr.
-		thisClassName = classNameToApply ifTrue:[
-		    changeListView selection:changeNr.
-		    self applyChange:changeNr.
-		    lastChange := changeNr
-		].
-	    ].
-	    self autoSelect:lastChange.
-	]
+        classNameToApply := self classNameOfChange:changeNr.
+        classNameToApply notNil ifTrue:[
+            self clearCodeView.
+            skipSignal isNil ifTrue:[skipSignal := Signal new].
+            changeNr to:(self numberOfChanges) do:[:changeNr |
+                thisClassName := self classNameOfChange:changeNr.
+                thisClassName = classNameToApply ifTrue:[
+                    changeListView setSelection:changeNr.
+                    self applyChange:changeNr.
+                    lastChange := changeNr
+                ].
+            ].
+            self autoSelect:lastChange.
+        ]
     ]
+
+    "Modified: 25.5.1996 / 12:26:25 / cg"
 !
 
 doApplyRest
     "user wants all changes from changeNr to be applied"
 
     self withSelectedChangeDo:[:changeNr |
-	self clearCodeView.
-	skipSignal isNil ifTrue:[skipSignal := Signal new].
-	changeNr to:(self numberOfChanges) do:[:changeNr |
-	    changeListView selection:changeNr.
-	    self applyChange:changeNr
-	].
-	self autoSelect:self numberOfChanges.
+        self clearCodeView.
+        skipSignal isNil ifTrue:[skipSignal := Signal new].
+        changeNr to:(self numberOfChanges) do:[:changeNr |
+            changeListView setSelection:changeNr.
+            self applyChange:changeNr
+        ].
+        self autoSelect:self numberOfChanges.
     ]
+
+    "Modified: 25.5.1996 / 12:26:28 / cg"
 !
 
 doBrowse
@@ -1868,7 +1879,7 @@
         "finally delete what has been found"
 
         (deleteSet size > 0) ifTrue:[
-            changeListView deselect.
+            changeListView setSelection:nil.
             index := deleteSet size.
             [index > 0] whileTrue:[
                 self silentDeleteChange:(deleteSet at:index).
@@ -1887,7 +1898,7 @@
     self newLabel:''.
 
     "Created: 3.12.1995 / 14:29:54 / cg"
-    "Modified: 14.12.1995 / 20:58:22 / cg"
+    "Modified: 25.5.1996 / 13:02:47 / cg"
 !
 
 doDelete
@@ -1906,20 +1917,21 @@
     "delete all changes with same class as currently selected change"
 
     self withSelectedChangeDo:[:changeNr |
-	| classNameToDelete |
+        | classNameToDelete |
 
-	classNameToDelete := self classNameOfChange:changeNr.
-	classNameToDelete notNil ifTrue:[
-	    changeListView selection:nil.
-	    self silentDeleteChangesFor:classNameToDelete
-				   from:1
-				     to:(self numberOfChanges).
-	    self setChangeList. 
-	    self autoSelectOrEnd:changeNr
-	]
+        classNameToDelete := self classNameOfChange:changeNr.
+        classNameToDelete notNil ifTrue:[
+            changeListView setSelection:nil.
+            self silentDeleteChangesFor:classNameToDelete
+                                   from:1
+                                     to:(self numberOfChanges).
+            self setChangeList. 
+            self autoSelectOrEnd:changeNr
+        ]
     ]
 
     "Created: 13.12.1995 / 16:07:14 / cg"
+    "Modified: 25.5.1996 / 12:26:31 / cg"
 !
 
 doDeleteClassFromBeginning
@@ -1932,7 +1944,7 @@
 
         classNameToDelete := self classNameOfChange:changeNr.
         classNameToDelete notNil ifTrue:[
-            changeListView selection:nil.
+            changeListView setSelection:nil.
             self silentDeleteChangesFor:classNameToDelete 
                                    from:1 
                                      to:changeNr.
@@ -1942,25 +1954,27 @@
     ]
 
     "Created: 13.12.1995 / 15:41:58 / cg"
-    "Modified: 13.12.1995 / 15:43:20 / cg"
+    "Modified: 25.5.1996 / 12:26:34 / cg"
 !
 
 doDeleteClassRest
     "delete rest of changes with same class as currently selected change"
 
     self withSelectedChangeDo:[:changeNr |
-	| classNameToDelete |
+        | classNameToDelete |
 
-	classNameToDelete := self classNameOfChange:changeNr.
-	classNameToDelete notNil ifTrue:[
-	    changeListView selection:nil.
-	    self silentDeleteChangesFor:classNameToDelete 
-				   from:changeNr
-				     to:(self numberOfChanges).
-	    self setChangeList.
-	    self autoSelectOrEnd:changeNr
-	]
+        classNameToDelete := self classNameOfChange:changeNr.
+        classNameToDelete notNil ifTrue:[
+            changeListView setSelection:nil.
+            self silentDeleteChangesFor:classNameToDelete 
+                                   from:changeNr
+                                     to:(self numberOfChanges).
+            self setChangeList.
+            self autoSelectOrEnd:changeNr
+        ]
     ]
+
+    "Modified: 25.5.1996 / 12:26:39 / cg"
 !
 
 doDeleteRest
@@ -2102,24 +2116,26 @@
 
     changeNr := changeListView selection.
     changeNr notNil ifTrue:[
-	fileName := Dialog
-			requestFileName:'append changes to:'
-			default:''
-			ok:'append'
-			abort:'abort'
-			pattern:'*.chg'.
+        fileName := Dialog
+                        requestFileName:'append changes to:'
+                        default:''
+                        ok:'append'
+                        abort:'abort'
+                        pattern:'*.chg'.
 
-	fileName notNil ifTrue:[
-	    self withCursor:(Cursor write) do:[
-		changeNr to:(self numberOfChanges) do:[:changeNr |
-		    changeListView selection:changeNr.
-		    (self appendChange:changeNr toFile:fileName) ifFalse:[
-			^ self
-		    ]
-		]
-	    ]
-	].
+        fileName notNil ifTrue:[
+            self withCursor:(Cursor write) do:[
+                changeNr to:(self numberOfChanges) do:[:changeNr |
+                    changeListView setSelection:changeNr.
+                    (self appendChange:changeNr toFile:fileName) ifFalse:[
+                        ^ self
+                    ]
+                ]
+            ]
+        ].
     ]
+
+    "Modified: 25.5.1996 / 12:26:41 / cg"
 !
 
 doUpdate
@@ -2159,33 +2175,35 @@
 
     changeNr := changeListView selection.
     changeNr notNil ifTrue:[
-	fileName := Dialog
-			requestFileName:'append changes for class to:'
-			default:''
-			ok:'append'
-			abort:'abort'
-			pattern:'*.chg'.
+        fileName := Dialog
+                        requestFileName:'append changes for class to:'
+                        default:''
+                        ok:'append'
+                        abort:'abort'
+                        pattern:'*.chg'.
 
-	fileName notNil ifTrue:[
-	    self withCursor:(Cursor write) do:[
-		startNr to:(self numberOfChanges) do:[:changeNr |
-		    |thisClassName|
+        fileName notNil ifTrue:[
+            self withCursor:(Cursor write) do:[
+                startNr to:(self numberOfChanges) do:[:changeNr |
+                    |thisClassName|
 
-		    thisClassName := self classNameOfChange:changeNr.
-		    thisClassName = aClassName ifTrue:[
-			changeListView selection:changeNr.
-			(self appendChange:changeNr toFile:fileName) ifFalse:[
-			    ^ self
-			]
-		    ]
-		]
-	    ]
-	].
+                    thisClassName := self classNameOfChange:changeNr.
+                    thisClassName = aClassName ifTrue:[
+                        changeListView setSelection:changeNr.
+                        (self appendChange:changeNr toFile:fileName) ifFalse:[
+                            ^ self
+                        ]
+                    ]
+                ]
+            ]
+        ].
     ]
+
+    "Modified: 25.5.1996 / 12:26:44 / cg"
 ! !
 
 !ChangesBrowser class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libtool/ChangesBrowser.st,v 1.80 1996-05-18 15:46:10 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libtool/ChangesBrowser.st,v 1.81 1996-05-25 11:27:40 cg Exp $'
 ! !