UI fixes/tweaks.
authorJan Vrany <jan.vrany@fit.cvut.cz>
Tue, 14 Oct 2014 17:33:08 +0200
changeset 14769 8fbf2cc4645d
parent 14768 b53e6ab64de8
child 14770 6a3d59666ca8
UI fixes/tweaks.
Tools__LintRuleSettingsApplication.st
--- a/Tools__LintRuleSettingsApplication.st	Tue Oct 14 16:25:19 2014 +0200
+++ b/Tools__LintRuleSettingsApplication.st	Tue Oct 14 17:33:08 2014 +0200
@@ -219,22 +219,29 @@
 doAdd
     <resource: #uiCallback>
 
-    self doAdd: RBCompositeLintRule new
+    | ruleset |
 
-    "Modified: / 27-02-2013 / 11:25:55 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    ruleset := RBCompositeLintRule new.
+    ruleset name: 'New Rule Set ' , (self rulesetList size + 1) printString.
+    self doAdd: ruleset
+
+    "Modified: / 14-10-2014 / 16:30:47 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 doAdd: anRBCompositeLintRule
+    | dialog |
 
-    anRBCompositeLintRule name isNil ifTrue:[
-        anRBCompositeLintRule name: 'New Rule Set ' , (self rulesetList size + 1) printString
+    dialog := LintRuleEditDialog new.
+    dialog rule: anRBCompositeLintRule.
+    dialog open.
+    dialog accepted ifTrue:[ 
+        self rulesetList add: anRBCompositeLintRule.
+        self rulesetSelectionHolder value: anRBCompositeLintRule.
+        self updateModifiedChannel.
     ].
-    self rulesetList add: anRBCompositeLintRule.
-    self rulesetSelectionHolder value: anRBCompositeLintRule.
-    self updateModifiedChannel.
-    self doEdit.
 
     "Created: / 27-02-2013 / 11:25:55 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 14-10-2014 / 16:29:47 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 doCopy
@@ -273,27 +280,23 @@
 
     | file |
 
+    DIalog warn: 'Not yet implemented'.
+    ^ self.
+
     file := Dialog requestFileName: (resources string: 'Select file') default: (LastFileName ? Filename currentDirectory / 'exported-ruleset.st').
     file isEmptyOrNil ifTrue:[ ^ self ].
 
     self shouldImplement
 
-    "Modified: / 27-02-2013 / 23:53:38 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 14-10-2014 / 16:33:37 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 doImport
     <resource: #uiCallback>
 
-    "automatically generated by UIPainter..."
+    Dialog warn: 'Not yet implemented'
 
-    "*** the code below performs no action"
-    "*** (except for some feedback on the Transcript)"
-    "*** Please change as required and accept in the browser."
-    "*** (and replace this comment by something more useful ;-)"
-
-    "action to be defined here..."
-
-    Transcript showCR:self class name, ': action for doImport ...'.
+    "Modified: / 14-10-2014 / 16:33:04 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 doRemove
@@ -424,11 +427,11 @@
 !LintRuleSettingsApplication class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleSettingsApplication.st,v 1.6 2014-04-13 18:24:28 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleSettingsApplication.st,v 1.7 2014-10-14 15:33:08 vrany Exp $'
 !
 
 version_CVS
-    ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleSettingsApplication.st,v 1.6 2014-04-13 18:24:28 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleSettingsApplication.st,v 1.7 2014-10-14 15:33:08 vrany Exp $'
 ! !