`ChangeSetBrowser2`: few UX improvements when working with Cypress (Filetree) jv
authorJan Vrany <jan.vrany@fit.cvut.cz>
Thu, 20 Sep 2018 21:56:57 +0100
branchjv
changeset 18394 a1d5f7f3d845
parent 18369 4ccc3b5d656d
child 18445 73c795373547
`ChangeSetBrowser2`: few UX improvements when working with Cypress (Filetree) ... packages. Namely: * emember selected Cypress package directory and make it default next time. * use the directory name as changeset name (so it appears in changeset browser's titlebar).
Tools__ChangeSetBrowser2.st
--- a/Tools__ChangeSetBrowser2.st	Wed Aug 29 21:47:14 2018 +0100
+++ b/Tools__ChangeSetBrowser2.st	Thu Sep 20 21:56:57 2018 +0100
@@ -40,7 +40,7 @@
 		isWorkingNotHolder hasSelectionHolder showConflictsOnlyAspect
 		targetNameSpaceName showDefinitionsOnlyAspect'
 	classVariableNames:'ShowRemoved LastSelectionConditionString RecentTargetPackages
-		LastConfirmersExtent'
+		LastConfirmersExtent LastCypressPackagePath'
 	poolDictionaries:''
 	category:'Interface-Browsers-ChangeSet'
 !
@@ -2984,10 +2984,17 @@
 doOpen: aChangeSet
     <resource: #obsolete>
     "/ a bad name - implying opening a window...
-    self loadChangeSet: aChangeSet
+    self doOpenChangeSet: aChangeSet
 
     "Created: / 05-12-2009 / 13:43:32 / Jan Vrany <jan.vrany@fit.cvut.cz>"
     "Modified: / 27-07-2012 / 21:21:24 / cg"
+    "Modified: / 20-09-2018 / 11:09:34 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+!
+
+doOpenChangeSet: aChangeSet
+    self loadChangeSet: aChangeSet
+
+    "Created: / 20-09-2018 / 11:09:22 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 doOpenCurrent
@@ -3011,7 +3018,7 @@
 
     | file |
     [
-        file := Dialog requestDirectoryName:(resources string: 'Select Cypress Package')."/ pattern:'*.package'.
+        file := Dialog requestDirectoryName:(resources string: 'Select Cypress Package') default: LastCypressPackagePath ."/ pattern:'*.package'.
     ] on: Dialog aboutToOpenBoxNotificationSignal do:[:ex|
         | dialog |
 
@@ -3023,7 +3030,7 @@
     file isNil ifTrue:[^self].
     self doOpenCypress: file
 
-    "Modified: / 03-09-2012 / 11:53:54 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 20-09-2018 / 11:13:33 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 doOpenCypress: aStringOrFilename
@@ -3047,11 +3054,15 @@
 
     self showProgress: (resources string: 'Reading Cypress Package...') while: [
         changeset := ((Smalltalk at:#CypressReader) readPackageFrom: dir) asChangeSet.
-        self doOpen: changeset.
+        changeset name isNil ifTrue:[ 
+            changeset name: dir baseName.
+        ].
+        LastCypressPackagePath := dir pathName.
+        self doOpenChangeSet: changeset.
     ].
 
     "Created: / 03-09-2012 / 11:44:55 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 05-10-2015 / 18:12:07 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 20-09-2018 / 11:12:59 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 doOpenFile: aStringOrFilename
@@ -3070,15 +3081,15 @@
             self showingRegularChangesetHolder value: false.
         ].
         self allowRemove: false."/true.
-        self doOpen: cs.
+        self doOpenChangeSet: cs.
     ].
 
     "Created: / 09-02-2012 / 19:11:58 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 05-12-2012 / 11:38:49 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 20-09-2018 / 11:09:02 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 doOpenNew
-    self doOpen: ChangeSet new.
+    self doOpenChangeSet: ChangeSet new.
     self showFilterHolder value: false.
     self infoPanel
         reset;
@@ -3088,7 +3099,7 @@
         addButtonOK;
         show.
 
-    "Modified: / 01-08-2012 / 18:36:48 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 20-09-2018 / 11:08:47 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 doOpenNewWindow