--- a/AbstractSettingsApplication.st Wed Jan 25 10:38:53 2006 +0100
+++ b/AbstractSettingsApplication.st Wed Jan 25 11:07:52 2006 +0100
@@ -23,12 +23,13 @@
AbstractSettingsApplication subclass:#ByteCodeCompilerSettingsAppl
instanceVariableNames:'warnings warnSTX warnDollar warnOldStyle warnCommonMistakes
warnUnderscore warnCompatibility warnUnusedVars
- warnAboutWrongVariableNames allowQualifiedNames allowDollar
- allowReservedWordsAsSelectors allowOldStyleAssignment
- allowUnderscore allowDolphinExtensions allowSqueakExtensions
- justInTimeCompilation canLoadBinaries constantFoldingSelection
- keepSource constantFolding constantFoldingOptions
- fullDebugSupport immutableArrays enableUnderscore enableDollar'
+ warnAboutWrongVariableNames warnAboutBadComments
+ allowQualifiedNames allowDollar allowReservedWordsAsSelectors
+ allowOldStyleAssignment allowUnderscore allowDolphinExtensions
+ allowSqueakExtensions justInTimeCompilation canLoadBinaries
+ constantFoldingSelection keepSource constantFolding
+ constantFoldingOptions fullDebugSupport immutableArrays
+ enableUnderscore enableDollar'
classVariableNames:''
poolDictionaries:''
privateIn:AbstractSettingsApplication
@@ -665,9 +666,9 @@
collection: (
(VerticalPanelViewSpec
name: 'VerticalPanel2'
- layout: (LayoutFrame 20 0 0 0 600 0 178 0)
+ layout: (LayoutFrame 20 0 0 0 0 0.5 0 1)
horizontalLayout: left
- verticalLayout: center
+ verticalLayout: top
horizontalSpace: 3
verticalSpace: 3
component:
@@ -698,6 +699,36 @@
extent: (Point 600 22)
)
(CheckBoxSpec
+ label: 'OldStyle Assignment'
+ name: 'OldStyleAssignment'
+ enableChannel: warnings
+ model: warnOldStyle
+ translateLabel: true
+ extent: (Point 600 22)
+ )
+ (CheckBoxSpec
+ label: 'Possible Incompatibilities'
+ name: 'PossibleIncompatibilities'
+ enableChannel: warnings
+ model: warnCompatibility
+ translateLabel: true
+ extent: (Point 600 22)
+ )
+ )
+
+ )
+ )
+ (VerticalPanelViewSpec
+ name: 'VerticalPanel3'
+ layout: (LayoutFrame 0 0.5 0 0 0 1 0 1)
+ horizontalLayout: left
+ verticalLayout: top
+ horizontalSpace: 3
+ verticalSpace: 3
+ component:
+ (SpecCollection
+ collection: (
+ (CheckBoxSpec
label: 'Unused Method Variables'
name: 'UnusedMethodVariables'
enableChannel: warnings
@@ -706,14 +737,6 @@
extent: (Point 600 22)
)
(CheckBoxSpec
- label: 'OldStyle Assignment'
- name: 'OldStyleAssignment'
- enableChannel: warnings
- model: warnOldStyle
- translateLabel: true
- extent: (Point 600 22)
- )
- (CheckBoxSpec
label: 'Common Mistakes'
name: 'CommonMistakes'
enableChannel: warnings
@@ -722,18 +745,18 @@
extent: (Point 600 22)
)
(CheckBoxSpec
- label: 'Possible Incompatibilities'
- name: 'PossibleIncompatibilities'
+ label: 'Bad (non-English) Variable Names'
+ name: 'BadVariableNames'
enableChannel: warnings
- model: warnCompatibility
+ model: warnAboutWrongVariableNames
translateLabel: true
extent: (Point 600 22)
)
(CheckBoxSpec
- label: 'Bad (non-English) Variable Names'
- name: 'BadVariableNames'
+ label: 'Bad (empty) Comments'
+ name: 'BadComments'
enableChannel: warnings
- model: warnAboutWrongVariableNames
+ model: warnAboutBadComments
translateLabel: true
extent: (Point 600 22)
)
@@ -744,7 +767,7 @@
)
)
- extent: (Point 665 180)
+ extent: (Point 665 125)
)
(DividerSpec
name: 'Separator5'
@@ -807,6 +830,7 @@
!AbstractSettingsApplication::ByteCodeCompilerSettingsAppl methodsFor:'actions'!
basicSaveSettings
+ "/ todo: move all compiler interface to ParserFlags
Compiler warnings:self warnings value.
Compiler warnSTXSpecials:self warnSTX value.
@@ -816,7 +840,8 @@
Compiler warnCommonMistakes:self warnCommonMistakes value.
Compiler warnPossibleIncompatibilities:self warnCompatibility value.
Compiler warnUnusedVars:self warnUnusedVars value.
- Compiler warnAboutWrongVariableNames:self warnAboutWrongVariableNames value.
+ ParserFlags warnAboutWrongVariableNames:self warnAboutWrongVariableNames value.
+ ParserFlags warnAboutBadComments:self warnAboutBadComments value.
Compiler allowUnderscoreInIdentifier:self allowUnderscore value.
Compiler allowDollarInIdentifier:self allowDollar value.
@@ -885,7 +910,8 @@
self warnUnderscore value:(Compiler warnUnderscoreInIdentifier ? false).
self warnUnusedVars value:(Compiler warnUnusedVars ? false).
self warnings value:(Compiler warnings ? false).
- self warnAboutWrongVariableNames value:(Compiler warnAboutWrongVariableNames ? false).
+ self warnAboutWrongVariableNames value:(ParserFlags warnAboutWrongVariableNames ? false).
+ self warnAboutBadComments value:(ParserFlags warnAboutBadComments ? false).
self modifiedChannel value:false
!
@@ -1049,10 +1075,17 @@
^ justInTimeCompilation.
!
+warnAboutBadComments
+ warnAboutBadComments isNil ifTrue:[
+ warnAboutBadComments := (ParserFlags warnAboutBadComments ? false) asValue.
+ warnAboutBadComments onChangeSend:#updateModifiedChannel to:self.
+ ].
+ ^ warnAboutBadComments.
+!
+
warnAboutWrongVariableNames
-
warnAboutWrongVariableNames isNil ifTrue:[
- warnAboutWrongVariableNames := (Compiler warnAboutWrongVariableNames ? false) asValue.
+ warnAboutWrongVariableNames := (ParserFlags warnAboutWrongVariableNames ? false) asValue.
warnAboutWrongVariableNames onChangeSend:#updateModifiedChannel to:self.
].
^ warnAboutWrongVariableNames.
@@ -1165,6 +1198,7 @@
((Compiler warnPossibleIncompatibilities ? false) ~= self warnCompatibility value) ifTrue:[^ true].
((Compiler warnUnusedVars ? false) ~= self warnUnusedVars value) ifTrue:[^ true].
((Compiler warnAboutWrongVariableNames ? false) ~= self warnAboutWrongVariableNames value) ifTrue:[^ true].
+ ((ParserFlags warnAboutBadComments ? false) ~= self warnAboutBadComments value) ifTrue:[^ true].
((Compiler allowUnderscoreInIdentifier ? false) ~= self allowUnderscore value) ifTrue:[^ true].
((Compiler allowDollarInIdentifier ? false) ~= self allowDollar value) ifTrue:[^ true].
@@ -11870,5 +11904,5 @@
!AbstractSettingsApplication class methodsFor:'documentation'!
version
- ^ '$Header: /cvs/stx/stx/libtool/AbstractSettingsApplication.st,v 1.210 2006-01-11 15:35:54 cg Exp $'
-! !
+ ^ '$Header: /cvs/stx/stx/libtool/AbstractSettingsApplication.st,v 1.211 2006-01-25 10:07:52 cg Exp $'
+! !