#BUGFIX by mawalch
authormawalch
Wed, 24 Jan 2018 16:20:19 +0100
changeset 17955 d0ef962513da
parent 17954 cf28096d3fa4
child 17956 26c03fc9513b
#BUGFIX by mawalch class: BookmarkMenuBuilder changed: #menuItemGotoBookmark: When using a LabelAndIcon set it as #labelImage:, not as #label: as a #label: MUST be a string
BookmarkMenuBuilder.st
--- a/BookmarkMenuBuilder.st	Tue Jan 23 13:57:32 2018 +0100
+++ b/BookmarkMenuBuilder.st	Wed Jan 24 16:20:19 2018 +0100
@@ -129,21 +129,24 @@
     "Created: / 21-06-2011 / 08:08:26 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
-menuItemGotoBookmark:anObject 
-    |icon label|
+menuItemGotoBookmark:anObject
+    |label icon menuItem|
 
     label := anObject label.
     icon := anObject icon.
-    icon notNil ifTrue:[ label := LabelAndIcon label:label icon:icon ].
-    ^ (MenuItem
-        label:label
-        itemValue:#switchToBookmarkEntry:
-        argument:anObject)
-            activeHelpKey:(anObject helpText);
-            translateLabel:false.
+    menuItem := MenuItem
+                label:label
+                itemValue:#switchToBookmarkEntry:
+                argument:anObject.
+    icon notNil ifTrue:[ menuItem labelImage:(LabelAndIcon label:label icon:icon). ].
+    menuItem activeHelpKey:(anObject helpText).
+    menuItem translateLabel:false.
+
+    ^ menuItem
 
     "Created: / 21-06-2011 / 07:55:50 / Jan Vrany <jan.vrany@fit.cvut.cz>"
     "Modified: / 29-11-2011 / 11:21:20 / cg"
+    "Modified: / 24-01-2018 / 16:17:03 / mawalch"
 ! !
 
 !BookmarkMenuBuilder methodsFor:'visiting'!