#BUGFIX by stefan
class: Tools::NewSystemBrowser
changed: #acceptMethod:inClass:language:check:
fix lost selector label in window title after accept
--- a/Tools__NewSystemBrowser.st Wed Mar 22 21:48:15 2017 +0100
+++ b/Tools__NewSystemBrowser.st Fri Mar 24 09:37:52 2017 +0100
@@ -1,5 +1,3 @@
-"{ Encoding: utf8 }"
-
"
COPYRIGHT (c) 2000 by eXept Software AG
All Rights Reserved
@@ -16,62 +14,62 @@
"{ NameSpace: Tools }"
SystemBrowser subclass:#NewSystemBrowser
- instanceVariableNames:'environmentHolder environment navigationState bufferNameList
- selectedBuffer buffers bufferUsageOrder browserCanvas
- immediateUpdate showClassPackages lastMethodCategory
- lastMethodMoveClass browserCanvasType
- syntaxColoringProcessRunning syntaxColoringProcess
- methodInfoProcess browsletShowHideLabelHolder browserPageCanvas
- isEmbedded hasNonEmptyEnvironmentSelectedHolder
- smalllintRulesOrAllHolder smalllintRulesOrDefaultHolder
- explainProcess'
- classVariableNames:'LastNewProtocols LastProtocolRenames LastCategoryRenames
- LastCategoryRenameOld LastCategoryRenameNew LastProjectMoves
- LastNameSpaceMove LastMethodMoveOrCopyTargetClass
- LastClassFilterBlockString LastMethodFilterBlockString
- LastBreakPointConditionString LastIndividualChecks
- LastAcceptPackage LastVariableRenames LastVisitorClassName
- LastTemporaryVariableName FindHistory SynchronousUpdate
- DoubleClickIsOpenBrowser ShowMethodTemplateWhenProtocolIsSelected
- DefaultShowMethodInheritance DefaultEmphasizeUnloadedClasses
- DefaultImmediateSyntaxColoring DefaultImmediateExplaining
- DefaultSyntaxColoring DefaultToolBarVisible
- DefaultCodeInfoVisible DefaultShortNameInTabs
- DefaultHideUnloadedClasses DefaultMarkApplications
- DefaultAutoFormat DefaultShowMethodComplexity
- DefaultShowMethodTypeIcon DefaultShowSpecialResourceEditors
- DefaultShowSyntheticMethods SharedMethodCategoryCache
- LastMethodProcessingBlockString LastLoadedPackages
- DefaultShortAllClassesInNameSpaceOrganisation LastBaseVersionTag
- LastTag DefaultShowPseudoProtocols DefaultShowMultitabMode
- LastRenamedOld LastRenamedNew LastImportedPackage
- LastLintRulesHolder NewNavigationHistory
- LastLiteralReplacementType LastLiteralReplacementNewName
- LastLiteralReplacementOldLiteral LastNewProjectType
- LastClassProcessingBlockString RecentlyClosedList
- LastClassSearchBoxShowedFullName CachedTagToRevisionMapping
- CachedMethodsImplemented LastCypressDirectory
- LastClassSearchBoxShowedJavaOnly LastRemoteRepository
- LastClassDocDirectory DefaultShowCoverage LastLintedPackage
- LastSearchedImplementors LastSearchedSenders
- LastComparedClassName SkipCompilabilityChecksForFastCheckin
- DefaultShowImageResourceMethodsImages'
- poolDictionaries:''
- category:'Interface-Browsers-New'
+ instanceVariableNames:'environmentHolder environment navigationState bufferNameList
+ selectedBuffer buffers bufferUsageOrder browserCanvas
+ immediateUpdate showClassPackages lastMethodCategory
+ lastMethodMoveClass browserCanvasType
+ syntaxColoringProcessRunning syntaxColoringProcess
+ methodInfoProcess browsletShowHideLabelHolder browserPageCanvas
+ isEmbedded hasNonEmptyEnvironmentSelectedHolder
+ smalllintRulesOrAllHolder smalllintRulesOrDefaultHolder
+ explainProcess'
+ classVariableNames:'LastNewProtocols LastProtocolRenames LastCategoryRenames
+ LastCategoryRenameOld LastCategoryRenameNew LastProjectMoves
+ LastNameSpaceMove LastMethodMoveOrCopyTargetClass
+ LastClassFilterBlockString LastMethodFilterBlockString
+ LastBreakPointConditionString LastIndividualChecks
+ LastAcceptPackage LastVariableRenames LastVisitorClassName
+ LastTemporaryVariableName FindHistory SynchronousUpdate
+ DoubleClickIsOpenBrowser ShowMethodTemplateWhenProtocolIsSelected
+ DefaultShowMethodInheritance DefaultEmphasizeUnloadedClasses
+ DefaultImmediateSyntaxColoring DefaultImmediateExplaining
+ DefaultSyntaxColoring DefaultToolBarVisible
+ DefaultCodeInfoVisible DefaultShortNameInTabs
+ DefaultHideUnloadedClasses DefaultMarkApplications
+ DefaultAutoFormat DefaultShowMethodComplexity
+ DefaultShowMethodTypeIcon DefaultShowSpecialResourceEditors
+ DefaultShowSyntheticMethods SharedMethodCategoryCache
+ LastMethodProcessingBlockString LastLoadedPackages
+ DefaultShortAllClassesInNameSpaceOrganisation LastBaseVersionTag
+ LastTag DefaultShowPseudoProtocols DefaultShowMultitabMode
+ LastRenamedOld LastRenamedNew LastImportedPackage
+ LastLintRulesHolder NewNavigationHistory
+ LastLiteralReplacementType LastLiteralReplacementNewName
+ LastLiteralReplacementOldLiteral LastNewProjectType
+ LastClassProcessingBlockString RecentlyClosedList
+ LastClassSearchBoxShowedFullName CachedTagToRevisionMapping
+ CachedMethodsImplemented LastCypressDirectory
+ LastClassSearchBoxShowedJavaOnly LastRemoteRepository
+ LastClassDocDirectory DefaultShowCoverage LastLintedPackage
+ LastSearchedImplementors LastSearchedSenders
+ LastComparedClassName SkipCompilabilityChecksForFastCheckin
+ DefaultShowImageResourceMethodsImages'
+ poolDictionaries:''
+ category:'Interface-Browsers-New'
!
ListEntry subclass:#OwnershipGraph
- instanceVariableNames:'ownershipInfo cachedForm'
- classVariableNames:''
- poolDictionaries:''
- privateIn:NewSystemBrowser
+ instanceVariableNames:'ownershipInfo cachedForm'
+ classVariableNames:''
+ poolDictionaries:''
+ privateIn:NewSystemBrowser
!
Object subclass:#RevisionOwnershipInfo
- instanceVariableNames:'revision author date lineOwnership'
- classVariableNames:''
- poolDictionaries:''
- privateIn:NewSystemBrowser::OwnershipGraph
+ instanceVariableNames:'revision author date lineOwnership'
+ classVariableNames:''
+ poolDictionaries:''
+ privateIn:NewSystemBrowser::OwnershipGraph
!
!NewSystemBrowser class methodsFor:'documentation'!
@@ -47588,7 +47586,7 @@
self activityNotification:nil.
browser := (UserPreferences current changeSetBrowserClass) openOn:previousMethods.
- browser window label:(resources string:'Revisions of %1 » %2' with:mclass name with:mselector).
+ browser window label:(resources string:'Revisions of %1 » %2' with:mclass name with:mselector).
browser readOnly:true.
].
@@ -52203,7 +52201,7 @@
label:[:chg |
|lbl|
"/ lbl := chg printString
- lbl := (chg className ? '???') , ' » ' , (chg selector ? '???') allBold.
+ lbl := (chg className ? '???') , ' » ' , (chg selector ? '???') allBold.
(chg isMethodChange and:[chg changeMethod isNil]) ifTrue:[
lbl := lbl asText allStrikedOut,' ','(removed)' allItalic.
].
@@ -58053,6 +58051,7 @@
"Created: / 24-02-2000 / 19:15:56 / cg"
"Modified: / 18-08-2000 / 16:04:33 / cg"
"Modified: / 27-04-2014 / 12:59:10 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+ "Modified (format): / 23-03-2017 / 19:58:11 / stefan"
!
noteBookView
@@ -62108,9 +62107,8 @@
self selectedMethods value:(Array with:rslt).
"/ self switchToSelector:rslt selector
] ifFalse:[
-"/ "/ do not notify myself (to avoid scroll-to-top)
-"/
-"/ self selectedMethods value:(Array with:rslt).
+ "/ do not notify myself (to avoid scroll-to-top)
+ self selectedMethods setValue:(Array with:rslt).
].
"/ self showMethodsCode:rslt scrollToTop:false.
"/ self selectedMethods setValue:(Array with:rslt).
@@ -62146,6 +62144,7 @@
"Created: / 30-12-2009 / 20:01:41 / Jan Vrany <jan.vrany@fit.cvut.cz>"
"Modified: / 02-08-2012 / 09:37:29 / cg"
"Modified (format): / 17-08-2014 / 10:12:29 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+ "Modified: / 24-03-2017 / 09:32:39 / stefan"
!
askForInitialApplicationCodeFor:aNewClass