- Added Integrity Check project menu item jv
authorJan Vrany <jan.vrany@fit.cvut.cz>
Thu, 23 Feb 2012 15:20:50 +0000
branchjv
changeset 12173 f135ea9fe1cf
parent 12172 047fafb1c37f
child 12174 2dcdea864585
- Added Integrity Check project menu item - Improvements in ProjectCheckerBrowser
Tools__NewSystemBrowser.st
Tools__ProjectCheckerBrowser.st
stx_libtool.st
--- a/Tools__NewSystemBrowser.st	Wed Feb 22 17:35:52 2012 +0000
+++ b/Tools__NewSystemBrowser.st	Thu Feb 23 15:20:50 2012 +0000
@@ -14946,7 +14946,7 @@
             enabled: hasProjectSelectedAndSourceCodeManagerHolder
             label: 'CheckOut Newest'
             itemValue: projectMenuCheckOutNewestUsingManagerNamed:
-            translateLabel: true                     
+            translateLabel: true
             labelImage: (ResourceRetriever ToolbarIconLibrary repositoryCheckOut 'CheckOut Newest')
             argument: SourceCodeManagerPlaceholder
             showBusyCursorWhilePerforming: true
@@ -15015,6 +15015,12 @@
             argument: SourceCodeManagerPlaceholder
           )
          (MenuItem
+            enabled: hasProjectSelectedAndSourceCodeManagerHolder
+            label: 'Integrity Check...'
+            itemValue: projectMenuCheckPackageIntegrity
+            translateLabel: true
+          )
+         (MenuItem
             label: '-'
             isVisible: false
           )
@@ -15046,7 +15052,7 @@
         nil
       )
 
-    "Modified: / 23-12-2011 / 19:23:21 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 23-02-2012 / 14:30:55 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 projectMenuSCMCompareBuildSupportFile
@@ -36600,6 +36606,28 @@
     "Modified: / 13-10-2006 / 01:31:43 / cg"
 !
 
+projectMenuCheckPackageIntegrity
+
+    | problems checker |
+
+    problems := OrderedCollection new.
+
+    self selectedProjectsDo:[:package |
+        checker := ProjectChecker check: package.
+        problems addAll: checker problems
+    ].
+
+    problems isEmpty ifTrue:[
+        Dialog information: 'Excellent!! No problems found!!'.
+    ] ifFalse:[
+        Tools::ProjectCheckerBrowser new
+            problemList: problems;
+            open
+    ]
+
+    "Created: / 23-02-2012 / 14:08:12 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+!
+
 projectMenuCheckRepositoryConsistency
     "check for container consistency in the source repository.
      That is: for every class in the project there must be a container (unstored classes),
@@ -55862,7 +55890,7 @@
 !NewSystemBrowser class methodsFor:'documentation'!
 
 version
-    ^ '$Id: Tools__NewSystemBrowser.st 7911 2012-02-22 09:55:48Z vranyj1 $'
+    ^ '$Id: Tools__NewSystemBrowser.st 7915 2012-02-23 15:20:50Z vranyj1 $'
 !
 
 version_CVS
@@ -55870,8 +55898,7 @@
 !
 
 version_SVN
-    ^ '$Id: Tools__NewSystemBrowser.st 7911 2012-02-22 09:55:48Z vranyj1 $'
+    ^ '$Id: Tools__NewSystemBrowser.st 7915 2012-02-23 15:20:50Z vranyj1 $'
 ! !
 
 NewSystemBrowser initialize!
-
--- a/Tools__ProjectCheckerBrowser.st	Wed Feb 22 17:35:52 2012 +0000
+++ b/Tools__ProjectCheckerBrowser.st	Thu Feb 23 15:20:50 2012 +0000
@@ -102,13 +102,15 @@
                     component: 
                    (SpecCollection
                       collection: (
-                       (TextEditorSpec
+                       (HTMLViewSpec
                           name: 'Description'
                           layout: (LayoutFrame 0 0 0 0 0 1 0 1)
-                          model: problemDescriptionAspect
+                          level: 0
+                          visibilityChannel: rationaleVisibleHolder
                           hasHorizontalScrollBar: true
                           hasVerticalScrollBar: true
-                          hasKeyboardFocusInitially: false
+                          htmlText: problemDescriptionAspect
+                          postBuildCallback: setupHTMLView:
                         )
                        )
                      
@@ -149,12 +151,12 @@
     |holder|
 
     (holder := builder bindingAt:#problemDescriptionAspect) isNil ifTrue:[
-        holder :=  (AspectAdaptor forAspect: #description)
+        holder :=  (AspectAdaptor forAspect: #descriptionAndActions)
                         subjectChannel: self problemSelectionHolder.
     ].
     ^ holder.
 
-    "Modified: / 13-02-2012 / 18:48:01 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 23-02-2012 / 14:32:57 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 problemListHolder
@@ -197,8 +199,18 @@
     ^ problemSelectionHolder.
 ! !
 
+!ProjectCheckerBrowser methodsFor:'hooks'!
+
+setupHTMLView:aView
+    aView painter
+        leftMargin:20;
+        topMargin:5.
+
+    "Created: / 23-02-2012 / 14:04:35 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+! !
+
 !ProjectCheckerBrowser class methodsFor:'documentation'!
 
 version_SVN
-    ^ '$Id: Tools__ProjectCheckerBrowser.st 7890 2012-02-14 17:08:43Z vranyj1 $'
+    ^ '$Id: Tools__ProjectCheckerBrowser.st 7915 2012-02-23 15:20:50Z vranyj1 $'
 ! !
--- a/stx_libtool.st	Wed Feb 22 17:35:52 2012 +0000
+++ b/stx_libtool.st	Thu Feb 23 15:20:50 2012 +0000
@@ -95,19 +95,19 @@
      exclude individual packages in the #excludedFromPrerequisites method."
 
     ^ #(
-        #'stx:goodies/refactoryBrowser/parser'    "RBProgramNodeVisitor - superclass of Tools::BreakpointBrowser::MessageArgumentExtractor "
-        #'stx:goodies/sunit'    "TestResult - referenced by Tools::TestRunner2>>debugError: "
-        #'stx:libbasic'    "CharacterArray - superclass of extended String "
-        #'stx:libbasic2'    "List - superclass of SettingsDialog::HierarchicalApplicationList "
+        #'stx:goodies/refactoryBrowser/parser'    "RBProgramNodeVisitor - superclass of CodeGenerator "
+        #'stx:goodies/sunit'    "TestCase - referenced by Tools::NewSystemBrowser>>classMenuNewTestCase "
+        #'stx:libbasic'    "ArithmeticValue - superclass of extended Integer "
+        #'stx:libbasic2'    "List - superclass of BookmarkList "
         #'stx:libbasic3'    "Change - superclass of extended CompositeChange "
-        #'stx:libboss'    "BinaryInputManager - referenced by Tools::Profiler class>>readStatisticsFrom: "
-        #'stx:libcomp'    "AbstractSyntaxHighlighter - superclass of SyntaxHighlighter2 "
-        #'stx:libhtml'    "HTMLDocumentView - referenced by Tools::NewSystemBrowser>>openDocumentation "
-        #'stx:libui'    "NamedSpec - superclass of EditFieldWithCompletionSpec "
-        #'stx:libview'    "DeviceGraphicsContext - superclass of EditFieldWithCompletion "
-        #'stx:libview2'    "Model - superclass of FileApplicationNoteBook::ArchiveViewApplication "
-        #'stx:libwidg'    "EditTextView - superclass of EditFieldWithCompletion "
-        #'stx:libwidg2'    "SyncedMultiColumnTextView - superclass of DiffTextView "
+        #'stx:libboss'    "BinaryOutputManager - referenced by Tools::Profiler>>storeStatisticsOn: "
+        #'stx:libcomp'    "Parser - superclass of SyntaxHighlighter2 "
+        #'stx:libhtml'    "HTMLDocumentView - referenced by AbstractLauncherApplication>>showPortInfo "
+        #'stx:libui'    "MenuComponentSpec - superclass of EditFieldWithCompletionSpec "
+        #'stx:libview'    "DeviceGraphicsContext - superclass of Tools::TagsBrowser::TagView "
+        #'stx:libview2'    "ToolApplicationModel - superclass of Tools::ChangeSetBrowser2 "
+        #'stx:libwidg'    "ListView - superclass of Tools::NewSystemBrowserCodeView "
+        #'stx:libwidg2'    "TwoColumnTextView - superclass of DiffCodeView "
     )
 ! !
 
@@ -387,7 +387,6 @@
         Method selectorPrintStringInBrowserFor:
         Method selectorPrintStringInBrowserFor:class:
         MethodDictionary inspectorClass
-        Object asTestCase
         Object inspect
         Object inspector2TabCommon
         Object inspector2TabForBasicInspect
@@ -464,6 +463,8 @@
         UnboxedIntegerArray inspector2TabForHexDump
         UnboxedIntegerArray inspector2Tabs
     )
+
+    "Modified: / 23-02-2012 / 15:18:38 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 ! !
 
 !stx_libtool class methodsFor:'description - project information'!
@@ -515,13 +516,13 @@
     "Return a SVN revision number of myself.
      This number is updated after a commit"
 
-    ^ "$SVN-Revision:"7911"$"
+    ^ "$SVN-Revision:"7913"$"
 ! !
 
 !stx_libtool class methodsFor:'documentation'!
 
 version
-    ^ '$Id: stx_libtool.st 7912 2012-02-22 13:18:20Z vranyj1 $'
+    ^ '$Id: stx_libtool.st 7915 2012-02-23 15:20:50Z vranyj1 $'
 !
 
 version_CVS
@@ -529,5 +530,5 @@
 !
 
 version_SVN
-    ^ '$Id: stx_libtool.st 7912 2012-02-22 13:18:20Z vranyj1 $'
+    ^ '$Id: stx_libtool.st 7915 2012-02-23 15:20:50Z vranyj1 $'
 ! !