#REFACTORING by cg
class: NewSystemBrowser
changed:
#bufferMenu
#categoryMenuSCMFor:
#classOtherClassNewSlice
#markAsProjectTagMenu
#menuForHistoryItems:
#scmMenuForManagerNamed:selector:
#selectorMenuNewSlice
#smalllintCheckMenuForEnvironment:
--- a/Tools__NewSystemBrowser.st Wed Feb 19 21:03:02 2020 +0100
+++ b/Tools__NewSystemBrowser.st Wed Feb 19 21:03:53 2020 +0100
@@ -54230,7 +54230,7 @@
] ifFalse:[
(m atNameKey:#'RemoveBuffer') disable
].
- m addItem:(MenuItem label:(resources string:'Exit') itemValue:#closeRequest).
+ m addItemLabel:(resources string:'Exit') value:#closeRequest.
m
].
@@ -54469,9 +54469,8 @@
m := Menu new.
allOtherLanguages do:[:eachLanguage |
"/ m addSeparator.
- m addItem:(MenuItem
- label:(resources string:'%1 Class' with:(eachLanguage name))
- itemValue:[self classMenuNewClass:eachLanguage metaClass ])
+ m addItemLabel:(resources string:'%1 Class' with:(eachLanguage name))
+ value:[self classMenuNewClass:eachLanguage metaClass ]
].
m
@@ -54962,10 +54961,8 @@
menu := Menu new.
tagsDefinedInAllProjects asOrderedCollection sort do:[:eachTag |
- menu addItem:
- (MenuItem
- label: eachTag asString
- itemValue:[ self selectorMenuMarkAs:eachTag ])
+ menu addItemLabel: eachTag asString
+ value:[ self selectorMenuMarkAs:eachTag ].
].
^ menu
@@ -54983,10 +54980,8 @@
menu := Menu new.
items do:[:historyEntry|
any := true.
- menu addItem:
- (MenuItem
- label: historyEntry displayString
- itemValue:[self switchToHistoryEntry: historyEntry])
+ menu addItemLabel: historyEntry displayString
+ value:[self switchToHistoryEntry: historyEntry]
].
any ifFalse:[^ nil ].
^ menu
@@ -55622,9 +55617,8 @@
allLanguages := ProgrammingLanguage allSortedByNameExcept:#isSmalltalk.
m := Menu new.
- m addItem:(MenuItem
- label:'Smalltalk Method'
- itemValue:[self selectorMenuNewMethod: SmalltalkLanguage instance]).
+ m addItemLabel:'Smalltalk Method'
+ value:[self selectorMenuNewMethod: SmalltalkLanguage instance].
allLanguages do:[:eachLanguage |
eachLanguage compilerClass notNil ifTrue:[
@@ -55783,10 +55777,8 @@
].
manager isNil ifTrue:[
menu := Menu new.
- menu addItem:
- (MenuItem
- label: (resources string: 'Unavailable - Configure SCM')
- itemValue: [self openSettingsDialogAndSelectSourceCodeManagement])
+ menu addItemLabel: (resources string: 'Unavailable - Configure SCM')
+ value: [self openSettingsDialogAndSelectSourceCodeManagement].
] ifFalse:[
menu := self menuFor: #categoryMenuSCMCommon.
].
@@ -56175,10 +56167,8 @@
].
manager isNil ifTrue:[
menu := Menu new.
- menu addItem:
- (MenuItem
- label: (resources string: 'Unavailable - Configure SCM')
- itemValue: [self openSettingsDialogAndSelectSourceCodeManagement])
+ menu addItemLabel: (resources string: 'Unavailable - Configure SCM')
+ value: [self openSettingsDialogAndSelectSourceCodeManagement]
] ifFalse:[
menu := self menuFor: selector.
menu itemsDo:[:item|
@@ -56319,22 +56309,19 @@
LastLintRulesHolder value notNil ifTrue:[
- menu addItem:
- (MenuItem label: (resources string: 'Run Again - %1' with: LastLintRulesHolder value displayString)
- itemValue: [ self smalllintRunOnEnvironment:rbenvironment ])
+ menu addItemLabel: (resources string: 'Run Again - %1' with: LastLintRulesHolder value displayString)
+ value: [ self smalllintRunOnEnvironment:rbenvironment ]
] ifFalse:[
menu addItem: (MenuItem label: (resources string: 'Run Again')
itemValue: [ self smalllintRunOnEnvironment:rbenvironment ]
enabled: false)
].
RBCompositeLintRule rulesets do:[:ruleset|
- menu addItem:
- (MenuItem label: (resources string: 'Run Checks - %1' with: ruleset displayString)
- itemValue: [ self smalllintRun:ruleset onEnvironment:rbenvironment ])
- ].
- menu addItem:
- (MenuItem label: (resources string: 'Run Selected...')
- itemValue: [ self smalllintRunSelectedOnEnvironment:rbenvironment ]).
+ menu addItemLabel: (resources string: 'Run Checks - %1' with: ruleset displayString)
+ value: [ self smalllintRun:ruleset onEnvironment:rbenvironment ]
+ ].
+ menu addItemLabel: (resources string: 'Run Selected...')
+ value: [ self smalllintRunSelectedOnEnvironment:rbenvironment ].
^ menu
"Created: / 27-11-2014 / 06:16:55 / Jan Vrany <jan.vrany@fit.cvut.cz>"