--- a/SimpleView.st Fri Sep 03 12:38:15 1999 +0200
+++ b/SimpleView.st Tue Sep 07 11:12:31 1999 +0200
@@ -3280,19 +3280,19 @@
self hiddenOnRealize:false.
realized ifFalse:[
- superView isNil "/ I am a topView
- ifTrue:[
- drawableId isNil ifTrue:[
- self realize.
- ] ifFalse:[
- self remap.
- ].
- ] ifFalse:[
- superView realized "/ superview already shown
- ifTrue:[
- self realize
- ]
- ]
+ superView isNil "/ I am a topView
+ ifTrue:[
+ drawableId isNil ifTrue:[
+ self realize.
+ ] ifFalse:[
+ self remap.
+ ].
+ ] ifFalse:[
+ superView realized "/ superview already shown
+ ifTrue:[
+ self realize
+ ]
+ ].
]
"
@@ -4722,9 +4722,9 @@
"
the old code was:
- realized := true.
- shown := true.
- ...
+ realized := true.
+ shown := true.
+ ...
this created a race condition, if the view was
realized and shortly after unrealized - before the mapped event
@@ -4735,30 +4735,31 @@
realized ifTrue:[
- "/ currently, the 'shown ifFalse:' optimization is
- "/ not ok, since 'shown' is also modified by visibilityChanges.
- "/ Also, when remapped, X11 only sends a mapped event for the topView.
- "/ Therefore, synthetically generate those #superViewMapped messages
- "/ in any case.
-
- shown := true.
- "
- backed views will not get expose events - have
- to force a redraw here to get things drawn into
- backing store.
- "
- backed ifTrue:[
- self redrawX:0 y:0 width:width height:height
- ].
-
- "/ tell my subViews ...
- subViews notNil ifTrue:[
- subViews do:[:v | v mapped
+ "/ currently, the 'shown ifFalse:' optimization is
+ "/ not ok, since 'shown' is also modified by visibilityChanges.
+ "/ Also, when remapped, X11 only sends a mapped event for the topView.
+ "/ Therefore, synthetically generate those #superViewMapped messages
+ "/ in any case.
+
+ shown := true.
+ "
+ backed views will not get expose events - have
+ to force a redraw here to get things drawn into
+ backing store.
+ "
+ backed ifTrue:[
+ self redrawX:0 y:0 width:width height:height
+ ].
+
+ "/ tell my subViews ...
+ subViews notNil ifTrue:[
+ subViews do:[:v | v mapped
"/ v shown ifFalse:[
"/ v mapped
"/ ]
- ]
- ]
+ ]
+ ].
+ self changed:#visibility.
]
"Modified: 25.2.1997 / 22:41:34 / cg"
@@ -4939,9 +4940,10 @@
shown := false.
subViews notNil ifTrue:[
- subViews do:[:v |
- v containerUnmapped
- ]
+ subViews do:[:v |
+ v containerUnmapped
+ ].
+ self changed:#visibility.
]
"Modified: 25.2.1997 / 22:40:52 / cg"
@@ -8272,6 +8274,6 @@
!SimpleView class methodsFor:'documentation'!
version
- ^ '$Header: /cvs/stx/stx/libview/SimpleView.st,v 1.336 1999-08-18 14:34:20 cg Exp $'
+ ^ '$Header: /cvs/stx/stx/libview/SimpleView.st,v 1.337 1999-09-07 09:12:31 tm Exp $'
! !
SimpleView initialize!