oops - restart with iconified views recreated them
authorClaus Gittinger <cg@exept.de>
Thu, 06 May 1999 09:50:49 +0200
changeset 2644 bb15778539af
parent 2643 737ca05060bb
child 2645 a82f50c19af1
oops - restart with iconified views recreated them deiconified (this error was introduced by the realized-flag handling change)
ModalBox.st
StandardSystemView.st
StdSysV.st
WGroup.st
WindowGroup.st
--- a/ModalBox.st	Wed May 05 23:04:37 1999 +0200
+++ b/ModalBox.st	Thu May 06 09:50:49 1999 +0200
@@ -383,10 +383,18 @@
 !
 
 reinitialize
-   super reinitialize.
-   self unmap.
+    "if I have already been reinited - return"
+    drawableId notNil ifTrue:[
+        ^ self
+    ].
+    "physically create the view & subviews"
+    self recreate.
 
-    "Modified: 3.5.1996 / 23:48:04 / stefan"
+"/   super reinitialize.
+"/   self unmap.
+
+    "Modified: / 3.5.1996 / 23:48:04 / stefan"
+    "Modified: / 6.5.1999 / 09:38:06 / cg"
 !
 
 resize
@@ -880,6 +888,6 @@
 !ModalBox class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libview/ModalBox.st,v 1.66 1999-04-24 20:05:30 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libview/ModalBox.st,v 1.67 1999-05-06 07:50:25 cg Exp $'
 ! !
 ModalBox initialize!
--- a/StandardSystemView.st	Wed May 05 23:04:37 1999 +0200
+++ b/StandardSystemView.st	Thu May 06 09:50:49 1999 +0200
@@ -955,7 +955,7 @@
 
     "if I have already been reinited - return"
     drawableId notNil ifTrue:[
-	^ self
+        ^ self
     ].
 
     "have to kludge with the controller 
@@ -967,22 +967,21 @@
     "physically create the view & subviews"
     self recreate.
 
-    "if I was mapped, do it again"
-    realized ifTrue:[
-	"if it was iconified, try to remap iconified"
-	device 
-	    mapView:self id:drawableId iconified:(shown not) 
-	    atX:left y:top width:width height:height
-	    minExtent:minExtent maxExtent:maxExtent.
+    "if I was iconified (not realized), remap iconified"
+    device 
+        mapView:self id:drawableId iconified:(realized "shown" not) 
+        atX:left y:top width:width height:height
+        minExtent:minExtent maxExtent:maxExtent.
 
-	"and restart the window-group process"
-	windowGroup notNil ifTrue:[
-	    windowGroup restart
-	]
+    "and restart the window-group process"
+    windowGroup notNil ifTrue:[
+        windowGroup restart
     ].
 
     "restore controller"
     controller := myController
+
+    "Modified: / 6.5.1999 / 09:50:13 / cg"
 !
 
 removeFromCurrentProject
@@ -1412,6 +1411,6 @@
 !StandardSystemView class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libview/StandardSystemView.st,v 1.111 1999-04-28 18:16:54 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libview/StandardSystemView.st,v 1.112 1999-05-06 07:49:43 cg Exp $'
 ! !
 StandardSystemView initialize!
--- a/StdSysV.st	Wed May 05 23:04:37 1999 +0200
+++ b/StdSysV.st	Thu May 06 09:50:49 1999 +0200
@@ -955,7 +955,7 @@
 
     "if I have already been reinited - return"
     drawableId notNil ifTrue:[
-	^ self
+        ^ self
     ].
 
     "have to kludge with the controller 
@@ -967,22 +967,21 @@
     "physically create the view & subviews"
     self recreate.
 
-    "if I was mapped, do it again"
-    realized ifTrue:[
-	"if it was iconified, try to remap iconified"
-	device 
-	    mapView:self id:drawableId iconified:(shown not) 
-	    atX:left y:top width:width height:height
-	    minExtent:minExtent maxExtent:maxExtent.
+    "if I was iconified (not realized), remap iconified"
+    device 
+        mapView:self id:drawableId iconified:(realized "shown" not) 
+        atX:left y:top width:width height:height
+        minExtent:minExtent maxExtent:maxExtent.
 
-	"and restart the window-group process"
-	windowGroup notNil ifTrue:[
-	    windowGroup restart
-	]
+    "and restart the window-group process"
+    windowGroup notNil ifTrue:[
+        windowGroup restart
     ].
 
     "restore controller"
     controller := myController
+
+    "Modified: / 6.5.1999 / 09:50:13 / cg"
 !
 
 removeFromCurrentProject
@@ -1412,6 +1411,6 @@
 !StandardSystemView class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libview/Attic/StdSysV.st,v 1.111 1999-04-28 18:16:54 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libview/Attic/StdSysV.st,v 1.112 1999-05-06 07:49:43 cg Exp $'
 ! !
 StandardSystemView initialize!
--- a/WGroup.st	Wed May 05 23:04:37 1999 +0200
+++ b/WGroup.st	Thu May 06 09:50:49 1999 +0200
@@ -623,11 +623,17 @@
     "destroy all views associated to this window group"
 
     topViews notNil ifTrue:[
-	topViews do:[:aTopView | aTopView notNil ifTrue:[aTopView destroy]]
+        topViews do:[:aTopView | 
+            aTopView notNil ifTrue:[
+                aTopView destroy
+            ]
+        ]
     ].
     views := nil.
     topViews := nil.
     mySensor := nil.
+
+    "Modified: / 6.5.1999 / 09:47:18 / cg"
 !
 
 realizeTopViews
@@ -642,36 +648,40 @@
     "Created: 24.7.1997 / 12:56:09 / cg"
 !
 
-rerealizeTopViews
-    "rerealize all topViews associated to this windowGroup.
-     and tell topViews about it."
+restart
+    "restart after a snapin.
+     This re-creates the windowGroup process and informs
+     my views."
+
+    topViews notNil ifTrue:[
+        "
+         need a new semaphore, since obsolete processes 
+         (from our previous live) may still sit on the current semaphore
+        "
+        mySensor eventSemaphore:(Semaphore new name:'WGroup eventSema').
+        isModal ifFalse:[
+            self startupWith:[self restartTopViews].
+        ]
+    ]
+
+    "Modified: / 6.5.1999 / 09:46:08 / cg"
+!
+
+restartTopViews
+    "inform all topViews associated to this windowGroup.
+     about the restart."
 
     topViews notNil ifTrue:[
         topViews do:[:aView |
             aView isPopUpView ifFalse:[
-                aView realize.
+"/                aView realize.
                 aView restarted
             ].
         ].
     ].
-!
 
-restart
-    "restart after a snapin.
-     This reopens all views in this group."
-
-    topViews notNil ifTrue:[
-	"
-	 need a new semaphore, since obsolete processes 
-	 (from our previous live) may still sit on the current semaphore
-	"
-	mySensor eventSemaphore:(Semaphore new name:'WGroup eventSema').
-	isModal ifFalse:[
-	    self startupWith:[self rerealizeTopViews].
-	]
-    ]
-
-    "Modified: 24.7.1997 / 13:00:12 / cg"
+    "Modified: / 6.5.1999 / 09:42:37 / cg"
+    "Created: / 6.5.1999 / 09:46:33 / cg"
 !
 
 shutDown
@@ -2023,6 +2033,6 @@
 !WindowGroup class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libview/Attic/WGroup.st,v 1.170 1999-04-24 19:52:52 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libview/Attic/WGroup.st,v 1.171 1999-05-06 07:50:49 cg Exp $'
 ! !
 WindowGroup initialize!
--- a/WindowGroup.st	Wed May 05 23:04:37 1999 +0200
+++ b/WindowGroup.st	Thu May 06 09:50:49 1999 +0200
@@ -623,11 +623,17 @@
     "destroy all views associated to this window group"
 
     topViews notNil ifTrue:[
-	topViews do:[:aTopView | aTopView notNil ifTrue:[aTopView destroy]]
+        topViews do:[:aTopView | 
+            aTopView notNil ifTrue:[
+                aTopView destroy
+            ]
+        ]
     ].
     views := nil.
     topViews := nil.
     mySensor := nil.
+
+    "Modified: / 6.5.1999 / 09:47:18 / cg"
 !
 
 realizeTopViews
@@ -642,36 +648,40 @@
     "Created: 24.7.1997 / 12:56:09 / cg"
 !
 
-rerealizeTopViews
-    "rerealize all topViews associated to this windowGroup.
-     and tell topViews about it."
+restart
+    "restart after a snapin.
+     This re-creates the windowGroup process and informs
+     my views."
+
+    topViews notNil ifTrue:[
+        "
+         need a new semaphore, since obsolete processes 
+         (from our previous live) may still sit on the current semaphore
+        "
+        mySensor eventSemaphore:(Semaphore new name:'WGroup eventSema').
+        isModal ifFalse:[
+            self startupWith:[self restartTopViews].
+        ]
+    ]
+
+    "Modified: / 6.5.1999 / 09:46:08 / cg"
+!
+
+restartTopViews
+    "inform all topViews associated to this windowGroup.
+     about the restart."
 
     topViews notNil ifTrue:[
         topViews do:[:aView |
             aView isPopUpView ifFalse:[
-                aView realize.
+"/                aView realize.
                 aView restarted
             ].
         ].
     ].
-!
 
-restart
-    "restart after a snapin.
-     This reopens all views in this group."
-
-    topViews notNil ifTrue:[
-	"
-	 need a new semaphore, since obsolete processes 
-	 (from our previous live) may still sit on the current semaphore
-	"
-	mySensor eventSemaphore:(Semaphore new name:'WGroup eventSema').
-	isModal ifFalse:[
-	    self startupWith:[self rerealizeTopViews].
-	]
-    ]
-
-    "Modified: 24.7.1997 / 13:00:12 / cg"
+    "Modified: / 6.5.1999 / 09:42:37 / cg"
+    "Created: / 6.5.1999 / 09:46:33 / cg"
 !
 
 shutDown
@@ -2023,6 +2033,6 @@
 !WindowGroup class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libview/WindowGroup.st,v 1.170 1999-04-24 19:52:52 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libview/WindowGroup.st,v 1.171 1999-05-06 07:50:49 cg Exp $'
 ! !
 WindowGroup initialize!