#REFACTORING by stefan
authorStefan Vogel <sv@exept.de>
Tue, 17 May 2016 11:00:44 +0200
changeset 5757 6b9528edde06
parent 5756 8bf39c14ecda
child 5758 e400a8f03e01
#REFACTORING by stefan class: TextView added: #replace: changed: #openSearchBoxAndSearch #searchDialogSpec Fix to not avoid output on Transcript: CheckBoxSpec [info]: application (a SimpleDialog) doesn't provide a #selectLines aspect.
TextView.st
--- a/TextView.st	Tue May 17 10:59:24 2016 +0200
+++ b/TextView.st	Tue May 17 11:00:44 2016 +0200
@@ -506,13 +506,13 @@
                 (CheckBoxSpec
                    label: 'Select Lines'
                    name: 'CheckBox3'
+                   layout: (LayoutFrame 0 0.0 0 0 0 1.0 24 0)
                    activeHelpKey: selectLines
                    level: 0
                    initiallyInvisible: true
                    tabable: true
-                   model: selectLines
+                   model: selectLinesHolder
                    translateLabel: true
-                   extent: (Point 302 24)
                  )
                 (CheckBoxSpec
                    label: 'Wrap at End of Text (forward only)'
@@ -554,7 +554,7 @@
                          acceptOnReturn: true
                          acceptOnTab: true
                          acceptOnPointerLeave: true
-                         extent: (Point 299 24)
+                         extent: (Point 284 24)
                        )
                       )
                     
@@ -2229,7 +2229,7 @@
     "
     |searchBox patternHolder caseHolder matchHolder matchWithRegexHolder wrapAtEndHolder
      fwd ign match initialString
-     bindings bldr doSearch modal searchVariableHolder selectedVariable searchFullWordHolder
+     bindings bldr doSearch modal searchVariableHolder selectedVariable searchFullWordHolder selectLinesHolder
      replaceBooleanEnabledHolder replaceBooleanHolder replaceTextHolder
      replaceAllBooleanHolder replacePreserveCaseBooleanHolder
      searchAtBeginOfLineOnlyHolder updateReturnKeyBehavior|
@@ -2265,6 +2265,7 @@
     searchVariableHolder := (lastSearchWasVariableSearch ? false) asValue.
     searchFullWordHolder := false asValue.
     searchAtBeginOfLineOnlyHolder := false asValue.
+    selectLinesHolder := false asValue.
     replaceBooleanHolder := ("LastSearchWasReplace ?" false) asValue.
     replaceAllBooleanHolder := false asValue.
     replacePreserveCaseBooleanHolder := false asValue.
@@ -2322,7 +2323,7 @@
                 searchAction := 
                     [
                         self searchUsingSpec:(
-                            ListView::SearchSpec new
+                            self class searchSpec new
                                 pattern:pattern
                                 ignoreCase:lastSearchIgnoredCase
                                 match: lastSearchWasMatch 
@@ -2443,6 +2444,7 @@
     bindings at:#searchFullWordEnabled put:true.
     bindings at:#searchAtBeginOfLineOnly put:searchAtBeginOfLineOnlyHolder.
     bindings at:#wrapAtEndOfTextHolder put:wrapAtEndHolder.
+    bindings at:#selectLinesHolder put:selectLinesHolder.
     
     bindings at:#replaceEnabled put:replaceBooleanEnabledHolder.
     bindings at:#replaceBoolean put:replaceBooleanHolder.
@@ -2523,6 +2525,13 @@
     "Created: / 08-03-2012 / 14:02:59 / cg"
 !
 
+replace:someText
+    "replace the selection by someText. I am readonly, so this is a no-op here.
+     Subclasses may redefine me."
+
+    ^ self.
+!
+
 save
     "save contents into a file
      - ask user for filename using a fileSelectionBox."