oops - clearing selection was wrong in MultiSelectionInList
authorca
Mon, 01 Apr 1996 20:56:26 +0200
changeset 526 8203430fbadd
parent 525 87524b8e35a6
child 527 fbe2fd7e796b
oops - clearing selection was wrong in MultiSelectionInList
MSelList.st
MultiSelectionInList.st
SelList.st
SelectionInList.st
--- a/MSelList.st	Fri Mar 29 03:08:00 1996 +0100
+++ b/MSelList.st	Mon Apr 01 20:56:26 1996 +0200
@@ -10,13 +10,11 @@
  hereby transferred.
 "
 
-'From Smalltalk/X, Version:2.10.5 on 25-mar-1995 at 12:12:09 pm'!
-
 SelectionInList subclass:#MultiSelectionInList
-	 instanceVariableNames:''
-	 classVariableNames:''
-	 poolDictionaries:''
-	 category:'Interface-Support-Models'
+	instanceVariableNames:''
+	classVariableNames:''
+	poolDictionaries:''
+	category:'Interface-Support-Models'
 !
 
 !MultiSelectionInList class methodsFor:'documentation'!
@@ -35,10 +33,6 @@
 "
 !
 
-version
-    ^ '$Header: /cvs/stx/stx/libwidg/Attic/MSelList.st,v 1.6 1996-02-11 11:59:15 cg Exp $'
-!
-
 documentation
 "
     Like a selectionInList, but allows for multiple selected items.
@@ -46,16 +40,20 @@
 "
 ! !
 
-!MultiSelectionInList methodsFor:'initialization'!
+!MultiSelectionInList methodsFor:'accessing-values'!
+
+selection
+    "return the selections value (i.e. the entry in the list"
+
+    |l|
 
-initialize
-    self listHolder:(nil asValue).      "/ could also use an empty collection here
-    self selectionIndexHolder:(Array new asValue).
+    l := self list.
+    ^ selectionIndexHolder value collect:[:index |
+	l at:index
+      ]
 
-    "Created: 26.10.1995 / 16:30:22 / cg"
-! !
-
-!MultiSelectionInList methodsFor:'accessing-values'!
+    "Created: 26.10.1995 / 16:52:27 / cg"
+!
 
 selection:anObjectList 
     "set the selection to be anObjectList."
@@ -75,19 +73,23 @@
     ^ self selectionIndex:indizes
 
     "Created: 26.10.1995 / 16:40:24 / cg"
-!
+! !
+
+!MultiSelectionInList methodsFor:'initialization'!
 
-selection
-    "return the selections value (i.e. the entry in the list"
-
-    |l|
+initialize
+    self listHolder:(nil asValue).      "/ could also use an empty collection here
+    self selectionIndexHolder:(Array new asValue).
 
-    l := self list.
-    ^ selectionIndexHolder value collect:[:index |
-	l at:index
-      ]
+    "Created: 26.10.1995 / 16:30:22 / cg"
+! !
+
+!MultiSelectionInList methodsFor:'private'!
 
-    "Created: 26.10.1995 / 16:52:27 / cg"
+clearSelection
+    selectionIndexHolder setValue:(Array new).
+
+
 ! !
 
 !MultiSelectionInList methodsFor:'selections'!
@@ -103,3 +105,8 @@
     ^ Array new
 ! !
 
+!MultiSelectionInList class methodsFor:'documentation'!
+
+version
+    ^ '$Header: /cvs/stx/stx/libwidg/Attic/MSelList.st,v 1.7 1996-04-01 18:56:26 ca Exp $'
+! !
--- a/MultiSelectionInList.st	Fri Mar 29 03:08:00 1996 +0100
+++ b/MultiSelectionInList.st	Mon Apr 01 20:56:26 1996 +0200
@@ -10,13 +10,11 @@
  hereby transferred.
 "
 
-'From Smalltalk/X, Version:2.10.5 on 25-mar-1995 at 12:12:09 pm'!
-
 SelectionInList subclass:#MultiSelectionInList
-	 instanceVariableNames:''
-	 classVariableNames:''
-	 poolDictionaries:''
-	 category:'Interface-Support-Models'
+	instanceVariableNames:''
+	classVariableNames:''
+	poolDictionaries:''
+	category:'Interface-Support-Models'
 !
 
 !MultiSelectionInList class methodsFor:'documentation'!
@@ -35,10 +33,6 @@
 "
 !
 
-version
-    ^ '$Header: /cvs/stx/stx/libwidg/MultiSelectionInList.st,v 1.6 1996-02-11 11:59:15 cg Exp $'
-!
-
 documentation
 "
     Like a selectionInList, but allows for multiple selected items.
@@ -46,16 +40,20 @@
 "
 ! !
 
-!MultiSelectionInList methodsFor:'initialization'!
+!MultiSelectionInList methodsFor:'accessing-values'!
+
+selection
+    "return the selections value (i.e. the entry in the list"
+
+    |l|
 
-initialize
-    self listHolder:(nil asValue).      "/ could also use an empty collection here
-    self selectionIndexHolder:(Array new asValue).
+    l := self list.
+    ^ selectionIndexHolder value collect:[:index |
+	l at:index
+      ]
 
-    "Created: 26.10.1995 / 16:30:22 / cg"
-! !
-
-!MultiSelectionInList methodsFor:'accessing-values'!
+    "Created: 26.10.1995 / 16:52:27 / cg"
+!
 
 selection:anObjectList 
     "set the selection to be anObjectList."
@@ -75,19 +73,23 @@
     ^ self selectionIndex:indizes
 
     "Created: 26.10.1995 / 16:40:24 / cg"
-!
+! !
+
+!MultiSelectionInList methodsFor:'initialization'!
 
-selection
-    "return the selections value (i.e. the entry in the list"
-
-    |l|
+initialize
+    self listHolder:(nil asValue).      "/ could also use an empty collection here
+    self selectionIndexHolder:(Array new asValue).
 
-    l := self list.
-    ^ selectionIndexHolder value collect:[:index |
-	l at:index
-      ]
+    "Created: 26.10.1995 / 16:30:22 / cg"
+! !
+
+!MultiSelectionInList methodsFor:'private'!
 
-    "Created: 26.10.1995 / 16:52:27 / cg"
+clearSelection
+    selectionIndexHolder setValue:(Array new).
+
+
 ! !
 
 !MultiSelectionInList methodsFor:'selections'!
@@ -103,3 +105,8 @@
     ^ Array new
 ! !
 
+!MultiSelectionInList class methodsFor:'documentation'!
+
+version
+    ^ '$Header: /cvs/stx/stx/libwidg/MultiSelectionInList.st,v 1.7 1996-04-01 18:56:26 ca Exp $'
+! !
--- a/SelList.st	Fri Mar 29 03:08:00 1996 +0100
+++ b/SelList.st	Mon Apr 01 20:56:26 1996 +0200
@@ -185,17 +185,17 @@
 
     changedObject == selectionIndexHolder ifTrue:[
 "/        self notifyChange:#selectionIndex
-	self changed:#selectionIndex
+        self changed:#selectionIndex
     ] ifFalse:[
-	changedObject == listHolder ifTrue:[
-	    something == #value ifTrue:[
-		selectionIndexHolder setValue:0.
+        changedObject == listHolder ifTrue:[
+            something == #value ifTrue:[
+                self clearSelection.
 "/                self notifyChange:#list.
 "/                selectionIndexHolder notifyChange:#value
-		self changed:#list.
-		selectionIndexHolder changed:#value
-	    ]
-	]
+                self changed:#list.
+                selectionIndexHolder changed:#value
+            ]
+        ]
     ]
 ! !
 
@@ -236,8 +236,14 @@
     ^ self selectionIndexHolder:aValueHolder
 ! !
 
+!SelectionInList methodsFor:'private'!
+
+clearSelection
+    selectionIndexHolder setValue:0.
+! !
+
 !SelectionInList class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libwidg/Attic/SelList.st,v 1.8 1996-02-11 11:53:44 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libwidg/Attic/SelList.st,v 1.9 1996-04-01 18:56:16 ca Exp $'
 ! !
--- a/SelectionInList.st	Fri Mar 29 03:08:00 1996 +0100
+++ b/SelectionInList.st	Mon Apr 01 20:56:26 1996 +0200
@@ -185,17 +185,17 @@
 
     changedObject == selectionIndexHolder ifTrue:[
 "/        self notifyChange:#selectionIndex
-	self changed:#selectionIndex
+        self changed:#selectionIndex
     ] ifFalse:[
-	changedObject == listHolder ifTrue:[
-	    something == #value ifTrue:[
-		selectionIndexHolder setValue:0.
+        changedObject == listHolder ifTrue:[
+            something == #value ifTrue:[
+                self clearSelection.
 "/                self notifyChange:#list.
 "/                selectionIndexHolder notifyChange:#value
-		self changed:#list.
-		selectionIndexHolder changed:#value
-	    ]
-	]
+                self changed:#list.
+                selectionIndexHolder changed:#value
+            ]
+        ]
     ]
 ! !
 
@@ -236,8 +236,14 @@
     ^ self selectionIndexHolder:aValueHolder
 ! !
 
+!SelectionInList methodsFor:'private'!
+
+clearSelection
+    selectionIndexHolder setValue:0.
+! !
+
 !SelectionInList class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libwidg/SelectionInList.st,v 1.8 1996-02-11 11:53:44 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libwidg/SelectionInList.st,v 1.9 1996-04-01 18:56:16 ca Exp $'
 ! !