#BUGFIX by stefan
authorStefan Vogel <sv@exept.de>
Wed, 22 May 2019 18:07:59 +0200
changeset 6054 8b6b5de90065
parent 6053 88091f958e67
child 6055 ecbbd4e84b0f
#BUGFIX by stefan class: DSVColumnView changed: #update:with:from: deselect when disabled fia enableChannel
DSVColumnView.st
--- a/DSVColumnView.st	Wed May 22 16:10:09 2019 +0200
+++ b/DSVColumnView.st	Wed May 22 18:07:59 2019 +0200
@@ -1,5 +1,3 @@
-"{ Encoding: utf8 }"
-
 "
  COPYRIGHT (c) 1997 by Claus Gittinger / eXept Software AG
               All Rights Reserved
@@ -16,46 +14,46 @@
 "{ NameSpace: Smalltalk }"
 
 View subclass:#DSVColumnView
-        instanceVariableNames:'labelView listHolder editValue editView multipleSelectOk useIndex
-                selectedColIndexHolder selectedRowIndex selectRowOnDefault
-                buttonMotionAction buttonReleaseAction rowHeight minRowHeight
-                columnDescriptors viewOrigin colorMap rowFontAscent lockRowIndex
-                rowIfAbsentBlock columnHolder registererImages list fgColor
-                separatorSize catchChangeEvents beDependentOfRows bgColor
-                actionBlock builder tabIntern doubleClickActionBlock
-                verticalSpacing horizontalSpacing rowSelectorForm
-                buttonLightColor buttonShadowColor buttonHalfLightColor
-                buttonHalfShadowColor checkToggleExtent checkToggleForm
-                checkToggleActiveImage checkTogglePassiveImage
-                checkToggleDisabledActiveImage checkToggleDisabledPassiveImage
-                checkToggleLevel radioButtonActiveImage radioButtonPassiveImage
-                radioButtonDisabledActiveImage radioButtonDisabledPassiveImage
-                comboButtonExtent comboButtonForm comboButtonDisabledForm
-                comboButtonLevel dropSource columnAdaptor tabAtEndAction
-                tabAtStartAction modifiedChannel autoScroll autoScrollBlock
-                needFitColumns scrollWhenUpdating separatorOneDColor
-                selectionForegroundColor selectionForegroundColorNoFocus
-                selectionBackgroundColor selectionBackgroundColorNoFocus
-                selectionFrameColor selectionFrameColorNoFocus previousExtent
-                selectConditionBlock scrollRowWise autoScrollToColumn
-                cachedPreferredExtent sortListInPlace labelFgColor labelBgColor
-                updateListHolderWhenSorting ignoreReselect didEditWithDialog'
-        classVariableNames:'DefaultForegroundColor DefaultBackgroundColor
-                DefaultHilightForegroundColor DefaultHilightBackgroundColor
-                DefaultHilightFrameColor ButtonLightColor ButtonShadowColor
-                CheckToggleActiveImage CheckTogglePassiveImage
-                CheckToggleDisabledActiveImage CheckToggleDisabledPassiveImage
-                ButtonHalfLightColor ButtonHalfShadowColor ButtonEdgeStyle
-                CheckToggleForm CheckToggleLevel CheckToggleExtent
-                ComboButtonForm ComboButtonDisabledForm ComboButtonLevel
-                ComboButtonExtent StopRedrawSignal RadioButtonActiveImage
-                RadioButtonPassiveImage RadioButtonDisabledActiveImage
-                RadioButtonDisabledPassiveImage PreselectAllWhenOpeningEditor
-                DefaultHilightForegroundColorNoFocus
-                DefaultHilightBackgroundColorNoFocus DefaultLabelForegroundColor
-                DefaultLabelBackgroundColor'
-        poolDictionaries:''
-        category:'Views-DataSet'
+	instanceVariableNames:'labelView listHolder editValue editView multipleSelectOk useIndex
+		selectedColIndexHolder selectedRowIndex selectRowOnDefault
+		buttonMotionAction buttonReleaseAction rowHeight minRowHeight
+		columnDescriptors viewOrigin colorMap rowFontAscent lockRowIndex
+		rowIfAbsentBlock columnHolder registererImages list fgColor
+		separatorSize catchChangeEvents beDependentOfRows bgColor
+		actionBlock builder tabIntern doubleClickActionBlock
+		verticalSpacing horizontalSpacing rowSelectorForm
+		buttonLightColor buttonShadowColor buttonHalfLightColor
+		buttonHalfShadowColor checkToggleExtent checkToggleForm
+		checkToggleActiveImage checkTogglePassiveImage
+		checkToggleDisabledActiveImage checkToggleDisabledPassiveImage
+		checkToggleLevel radioButtonActiveImage radioButtonPassiveImage
+		radioButtonDisabledActiveImage radioButtonDisabledPassiveImage
+		comboButtonExtent comboButtonForm comboButtonDisabledForm
+		comboButtonLevel dropSource columnAdaptor tabAtEndAction
+		tabAtStartAction modifiedChannel autoScroll autoScrollBlock
+		needFitColumns scrollWhenUpdating separatorOneDColor
+		selectionForegroundColor selectionForegroundColorNoFocus
+		selectionBackgroundColor selectionBackgroundColorNoFocus
+		selectionFrameColor selectionFrameColorNoFocus previousExtent
+		selectConditionBlock scrollRowWise autoScrollToColumn
+		cachedPreferredExtent sortListInPlace labelFgColor labelBgColor
+		updateListHolderWhenSorting ignoreReselect didEditWithDialog'
+	classVariableNames:'DefaultForegroundColor DefaultBackgroundColor
+		DefaultHilightForegroundColor DefaultHilightBackgroundColor
+		DefaultHilightFrameColor ButtonLightColor ButtonShadowColor
+		CheckToggleActiveImage CheckTogglePassiveImage
+		CheckToggleDisabledActiveImage CheckToggleDisabledPassiveImage
+		ButtonHalfLightColor ButtonHalfShadowColor ButtonEdgeStyle
+		CheckToggleForm CheckToggleLevel CheckToggleExtent
+		ComboButtonForm ComboButtonDisabledForm ComboButtonLevel
+		ComboButtonExtent StopRedrawSignal RadioButtonActiveImage
+		RadioButtonPassiveImage RadioButtonDisabledActiveImage
+		RadioButtonDisabledPassiveImage PreselectAllWhenOpeningEditor
+		DefaultHilightForegroundColorNoFocus
+		DefaultHilightBackgroundColorNoFocus DefaultLabelForegroundColor
+		DefaultLabelBackgroundColor'
+	poolDictionaries:''
+	category:'Views-DataSet'
 !
 
 !DSVColumnView class methodsFor:'documentation'!
@@ -1838,6 +1836,9 @@
         ^ self
     ].
     chgObj == enableChannel ifTrue:[
+        enableChannel value ifFalse:[
+            self deselect.  "Selected Checkboxes can still be edited, so deselect"
+        ].        
         self invalidate.
         ^ self
     ].
@@ -1939,8 +1940,8 @@
 
     "Modified: / 30-01-2000 / 12:16:49 / cg"
     "Modified: / 08-03-2018 / 18:06:19 / stefan"
-    "Modified: / 22-05-2019 / 16:03:54 / Stefan Vogel"
     "Modified: / 21-05-2019 / 17:22:20 / Claus Gittinger"
+    "Modified: / 22-05-2019 / 16:26:57 / Stefan Vogel"
 !
 
 updateColumnFromEditValue